Issue 9360002: cleanup postProcess step and output obsolete.json file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9360002: cleanup postProcess step and output obsolete.json file (Closed)

Created:
8 years, 10 months ago by Jacob

Modified:
8 years, 10 months ago

Reviewers:
nweiz, Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

cleanup postProcess step and output obsolete.json file Split postProcess.dart into util.dart, postProcess.dart and prettyPrint.dart so it is clear which code should be high quality and which is just debugging pretty print logic. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4018

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review fix #

Created: 8 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+108 lines, -583 lines)			Patch
M	utils/apidoc/mdn/extract.sh	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	utils/apidoc/mdn/obsolete.json	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	utils/apidoc/mdn/postProcess.dart	View	1 chunk	+10 lines, -490 lines	0 comments	Download
A +	utils/apidoc/mdn/prettyPrint.dart	View	7 chunks	+10 lines, -93 lines	0 comments	Download
A	utils/apidoc/mdn/util.dart	View	1 chunk	+85 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jacob

jmesserly, you can use obsolete.json to get a list of obsolete methods to remove from ...

8 years, 10 months ago (2012-02-07 23:06:10 UTC) #1

nweiz

lgtm https://chromiumcodereview.appspot.com/9360002/diff/1/utils/apidoc/mdn/util.dart File utils/apidoc/mdn/util.dart (right): https://chromiumcodereview.appspot.com/9360002/diff/1/utils/apidoc/mdn/util.dart#newcode7 utils/apidoc/mdn/util.dart:7: // filtering the database to select the best ...

8 years, 10 months ago (2012-02-08 01:18:40 UTC) #3

Jacob

8 years, 10 months ago (2012-02-08 01:20:32 UTC) #4

https://chromiumcodereview.appspot.com/9360002/diff/1/utils/apidoc/mdn/util.dart
File utils/apidoc/mdn/util.dart (right):

https://chromiumcodereview.appspot.com/9360002/diff/1/utils/apidoc/mdn/util.d...
utils/apidoc/mdn/util.dart:7: // filtering the database to select the best
matches per file.
On 2012/02/08 01:18:40, nweiz wrote:
> This isn't true any more

Done.

Expand Messages | Collapse Messages