Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 9359038: Allow named parameters in const constructor invocations. (Closed)

Created:
8 years, 10 months ago by karlklose
Modified:
8 years, 10 months ago
Reviewers:
zundel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow named parameters in const constructor invocations. The compile time constant analyzer visited the name of the parameter as identifier, which was not resolved. This resulted in an element of kind NONE, which was classified as non-constant. BUG=http://code.google.com/p/dart/issues/detail?id=1576 TEST=language/NamedArgumentInConstCreationTest Committed: https://code.google.com/p/dart/source/detail?r=4301

Patch Set 1 #

Patch Set 2 : Fix test expectations." #

Patch Set 3 : Minor edits. #

Patch Set 4 : Change test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M compiler/java/com/google/dart/compiler/ast/DartNamedExpression.java View 1 2 chunks +1 line, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java View 1 2 3 chunks +7 lines, -1 line 0 comments Download
M tests/language/language-leg.status View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A tests/language/src/NamedArgumentInConstCreationTest.dart View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
karlklose
The name part of the named expression representing the named argument was visited as unresolved ...
8 years, 10 months ago (2012-02-15 10:27:51 UTC) #1
zundel
8 years, 10 months ago (2012-02-15 13:16:10 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698