Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 9359016: Implement is-Operator for interfaces. (Closed)

Created:
8 years, 10 months ago by karlklose
Modified:
8 years, 10 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Implement is-Operator for interfaces. Also add a test for cyclic interface hierarchies to ResolverTest. Committed: https://code.google.com/p/dart/source/detail?r=4077

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M frog/leg/emitter.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M frog/tests/leg/src/ResolverTest.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M tests/co19/co19-leg.status View 3 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
8 years, 10 months ago (2012-02-08 17:21:54 UTC) #1
ahe
LGTM! Could you update the description to say "implement is-operator ..." before you submit? Cheers, ...
8 years, 10 months ago (2012-02-08 18:18:53 UTC) #2
karlklose
8 years, 10 months ago (2012-02-09 14:05:58 UTC) #3
On 2012/02/08 18:18:53, ahe wrote:
> LGTM!
> 
> Could you update the description to say "implement  is-operator ..." before
you
> submit?
> 
> Cheers,
> Peter

Done. Thank you for the review, Peter.

Powered by Google App Engine
This is Rietveld 408576698