isolates in frog: playing with API improvements

isolates in frog: playing with API improvements

Committed: https://code.google.com/p/dart/source/detail?r=4153

[Siggi Cherem (dart-lang), 2012-02-10 22:38:50]

Here is a first CL that does some of the improvements we've been discussing, and
some that we proposed recently:
- adds support for Isolate.fromCode(topLevelFunction)
- adds BufferedSendPort so that we don't need to use a Future to retrieve the
port of a spawned isolate.
- adds several tests showing some examples. 

As we make progress in our discussion, we can tweak this around, what I'm mainly
interested is that we have the mechanisms in place and iterate. Isolate.fromUri
is next :)

[eub, 2012-02-10 22:46:18]

LGTM with minor suggestions.

Thanks!  Some stale comments on earlier drafts, please ignore those.

https://chromiumcodereview.appspot.com/9358010/diff/1001/frog/lib/corelib.dart
File frog/lib/corelib.dart (right):

https://chromiumcodereview.appspot.com/9358010/diff/1001/frog/lib/corelib.dar...
frog/lib/corelib.dart:29: #source("newisolate.dart"); // work in progress
towards the new API
alphabetize

https://chromiumcodereview.appspot.com/9358010/diff/1001/frog/lib/isolate_ser...
File frog/lib/isolate_serialization.dart (right):

https://chromiumcodereview.appspot.com/9358010/diff/1001/frog/lib/isolate_ser...
frog/lib/isolate_serialization.dart:137: throw "interal error: must call
_waitForPendingPorts to ensure all"
"internal"

https://chromiumcodereview.appspot.com/9358010/diff/1001/frog/lib/newisolate....
File frog/lib/newisolate.dart (right):

https://chromiumcodereview.appspot.com/9358010/diff/1001/frog/lib/newisolate....
frog/lib/newisolate.dart:12: * methods to control it's behavior remotely.
its

https://chromiumcodereview.appspot.com/9358010/diff/1001/tests/isolate/src/AP...
File tests/isolate/src/APIv2_spawnStandaloneTest.dart (right):

https://chromiumcodereview.appspot.com/9358010/diff/1001/tests/isolate/src/AP...
tests/isolate/src/APIv2_spawnStandaloneTest.dart:1: // Copyright (c) 2011, the
Dart project authors.  Please see the AUTHORS file
Update yer boilerplate. :)

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/corelib.dart
File frog/lib/corelib.dart (right):

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/corelib.dar...
frog/lib/corelib.dart:29: #source("newisolate.dart"); // work in progress
towards the new API
alphabetize

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/isolate.dart
File frog/lib/isolate.dart (right):

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/isolate.dar...
frog/lib/isolate.dart:392: // We force serialization/deserialization as a simple
way to ensure isolate
Line length?

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/isolate.dar...
frog/lib/isolate.dart:464: /** A port that buffers messages until an underlying
port gets resolve. */
("resolved")

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/isolate.dar...
frog/lib/isolate.dart:466: static int _bufferingCount = 0;
A comment, please.

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/isolate.dar...
frog/lib/isolate.dart:469: final int id;
Why public?

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/isolate.dar...
frog/lib/isolate.dart:485: _bufferingCount++;
id = _bufferingCount++
?
or a static fn that exposes the "unique counter id" notion.

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/isolate.dar...
frog/lib/isolate.dart:489: p.send(message[0], message[1]);
Raw access to numeric indices is oogy.

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/isolate.dar...
frog/lib/isolate.dart:700: final iid = _globalState.currentContext == null ? '?'
: '${_globalState.currentContext.id }';
Dead code?

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/isolate_ser...
File frog/lib/isolate_serialization.dart (right):

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/isolate_ser...
frog/lib/isolate_serialization.dart:137: throw "interal error: must call
_waitForPendingPorts to ensure all"
"internal"
and below

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/newisolate....
File frog/lib/newisolate.dart (right):

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/newisolate....
frog/lib/newisolate.dart:12: * methods to control it's behavior remotely.
its

[Siggi Cherem (dart-lang), 2012-02-10 23:42:22]

thanks!

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/corelib.dart
File frog/lib/corelib.dart (right):

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/corelib.dar...
frog/lib/corelib.dart:29: #source("newisolate.dart"); // work in progress
towards the new API
On 2012/02/10 22:46:19, eub wrote:
> alphabetize

Done.

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/isolate.dart
File frog/lib/isolate.dart (right):

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/isolate.dar...
frog/lib/isolate.dart:392: // We force serialization/deserialization as a simple
way to ensure isolate
On 2012/02/10 22:46:19, eub wrote:
> Line length?

Done.

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/isolate.dar...
frog/lib/isolate.dart:464: /** A port that buffers messages until an underlying
port gets resolve. */
On 2012/02/10 22:46:19, eub wrote:
> ("resolved")

Done.

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/isolate.dar...
frog/lib/isolate.dart:466: static int _bufferingCount = 0;
On 2012/02/10 22:46:19, eub wrote:
> A comment, please.

Done.

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/isolate.dar...
frog/lib/isolate.dart:469: final int id;
On 2012/02/10 22:46:19, eub wrote:
> Why public?

no reason. done

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/isolate.dar...
frog/lib/isolate.dart:485: _bufferingCount++;
On 2012/02/10 22:46:19, eub wrote:
> id = _bufferingCount++
> ?
> or a static fn that exposes the "unique counter id" notion.

Unfortunately, if I move the id initialization here, I can't make it final :(

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/isolate.dar...
frog/lib/isolate.dart:489: p.send(message[0], message[1]);
On 2012/02/10 22:46:19, eub wrote:
> Raw access to numeric indices is oogy.

Done - made into a map record.

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/isolate.dar...
frog/lib/isolate.dart:700: final iid = _globalState.currentContext == null ? '?'
: '${_globalState.currentContext.id }';
On 2012/02/10 22:46:19, eub wrote:
> Dead code?

yep, done.

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/isolate_ser...
File frog/lib/isolate_serialization.dart (right):

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/isolate_ser...
frog/lib/isolate_serialization.dart:137: throw "interal error: must call
_waitForPendingPorts to ensure all"
On 2012/02/10 22:46:19, eub wrote:
> "internal"
> and below

Done.

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/newisolate....
File frog/lib/newisolate.dart (right):

https://chromiumcodereview.appspot.com/9358010/diff/3001/frog/lib/newisolate....
frog/lib/newisolate.dart:12: * methods to control it's behavior remotely.
On 2012/02/10 22:46:19, eub wrote:
> its

Doh! thanks