Issue 9355048: Return newValue from indexSet helper and other intercepted setters. Also, throw IllegalArgumentExce…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9355048: Return newValue from indexSet helper and other intercepted setters. Also, throw IllegalArgumentExce… (Closed)

Created:
8 years, 10 months ago by ahe

Modified:
8 years, 10 months ago

Reviewers:
ngeoffray, kasperl

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen, karlklose, floitsch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Return newValue from indexSet helper and other intercepted setters. Also, throw IllegalArgumentException on negative length in getRange interceptor. Committed: https://code.google.com/p/dart/source/detail?r=4445

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -6 lines)			Patch
	M	dart/frog/leg/lib/js_helper.dart	View		3 chunks	+4 lines, -1 line	0 comments	Download
	M	dart/tests/corelib/corelib-leg.status	View		2 chunks	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages