Issue 9355032: Implement Strings API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9355032: Implement Strings API. (Closed)

Created:
8 years, 10 months ago by ahe

Modified:
8 years, 10 months ago

Reviewers:
ngeoffray, kasperl

CC:
reviews_dartlang.org, karlklose, floitsch, Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement Strings API. Committed: https://code.google.com/p/dart/source/detail?r=4433

Patch Set 1 #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -17 lines)			Patch
M	dart/frog/leg/lib/js_helper.dart	View	1 chunk	+7 lines, -0 lines	2 comments	Download
M	dart/frog/leg/lib/mockimpl.dart	View	1 chunk	+26 lines, -3 lines	0 comments	Download
M	dart/tests/co19/co19-leg.status	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	dart/tests/corelib/corelib-leg.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	dart/tests/language/language-leg.status	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://chromiumcodereview.appspot.com/9355032/diff/1/dart/frog/leg/lib/js_helper.dart File dart/frog/leg/lib/js_helper.dart (right): https://chromiumcodereview.appspot.com/9355032/diff/1/dart/frog/leg/lib/js_helper.dart#newcode396 dart/frog/leg/lib/js_helper.dart:396: for (var i in charCodes) { Would it ...

8 years, 10 months ago (2012-02-20 10:48:50 UTC) #2

ahe

Hi Kasper, Thank you for your comments. I'll rename isJSArray (have been thinking about it ...

8 years, 10 months ago (2012-02-20 16:35:26 UTC) #3

LGTM

Expand Messages | Collapse Messages