Issue 9355014: Two minor bug fixes: a type error in the parser, and throwing the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9355014: Two minor bug fixes: a type error in the parser, and throwing the (Closed)

Created:
8 years, 10 months ago by ahe

Modified:
8 years, 10 months ago

Reviewers:
floitsch, ngeoffray, kasperl

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen, kasperl, karlklose

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Two minor bug fixes: a type error in the parser, and throwing the correct exceptions on indexed access. Committed: https://code.google.com/p/dart/source/detail?r=4384

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -23 lines)			Patch
M	dart/frog/leg/lib/js_helper.dart	View	3 chunks	+12 lines, -13 lines	0 comments	Download
M	dart/frog/leg/scanner/partial_parser.dart	View	1 chunk	+10 lines, -3 lines	0 comments	Download
M	dart/tests/co19/co19-leg.status	View	3 chunks	+0 lines, -6 lines	0 comments	Download
M	dart/tests/corelib/corelib-leg.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

floitsch

I'm not familiar enough with the parser, but the rest LGTM.

8 years, 10 months ago (2012-02-17 22:40:08 UTC) #2

LGTM!