Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 9355006: Issue 1475. Report warning for non-unique Map literal keys. (Closed)

Created:
8 years, 10 months ago by scheglov
Modified:
8 years, 10 months ago
Reviewers:
codefu
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 1475. Report warning for non-unique Map literal keys. http://code.google.com/p/dart/issues/detail?id=1475 R=codefu@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4360

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M client/html/release/htmlimpl.dart View 1 chunk +0 lines, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 2 chunks +15 lines, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 10 months ago (2012-02-17 17:46:02 UTC) #1
codefu
8 years, 10 months ago (2012-02-17 17:48:39 UTC) #2
On 2012/02/17 17:46:02, scheglov wrote:

LGTM

Powered by Google App Engine
This is Rietveld 408576698