Issue 9350034: Fix kqueue handling of no timeout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9350034: Fix kqueue handling of no timeout (Closed)

Created:
8 years, 10 months ago by Søren Gjesse

Modified:
8 years, 10 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, Mads Ager (google)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix kqueue handling of no timeout Using a tiemout value of 0 when there was no timeout caused busy looping int the eventhandler thread as that actually ment immediate timeout. No timeout is specified using NULL. BUG=dart:1641 R=iposva@google.com TEST= Committed: https://code.google.com/p/dart/source/detail?r=4176

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	runtime/bin/eventhandler_macos.cc	View		1 chunk	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM -ip

Expand Messages | Collapse Messages