Issue 9350022: Add frog build target on Windows and change frogium and webdriver components to use frog instead ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9350022: Add frog build target on Windows and change frogium and webdriver components to use frog instead ... (Closed)

Created:
8 years, 10 months ago by Emily Fortuna

Modified:
8 years, 10 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add frog build target on Windows and change frogium and webdriver components to use frog instead of frogsh. Committed: https://code.google.com/p/dart/source/detail?r=4006

Patch Set 1 : '' #

Total comments: 1

Patch Set 2 : '' #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -2 lines)			Patch
A	frog/scripts/bootstrap/frog.bat	View	1	1 chunk	+21 lines, -0 lines	0 comments	Download
M	frog/scripts/bootstrap/frog_bootstrap_wrapper.py	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	tools/testing/dart/test_suite.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

8 years, 10 months ago (2012-02-07 20:41:54 UTC) #2

lgtm (with comments below)

https://chromiumcodereview.appspot.com/9350022/diff/3001/frog/scripts/bootstr...
File frog/scripts/bootstrap/frog.bat (right):

https://chromiumcodereview.appspot.com/9350022/diff/3001/frog/scripts/bootstr...
frog/scripts/bootstrap/frog.bat:1: @echo off
+ license comment
+ comment explaining this is a wrapper script to call frog in windows and that
it is used by the build bots

Expand Messages | Collapse Messages