Issue 9350016: Add test cases for issue 1569.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9350016: Add test cases for issue 1569. (Closed)

Created:
8 years, 10 months ago by kasperl

Modified:
8 years, 10 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add test cases for issue 1569. R=ahe@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3990

Patch Set 2 : Address review feedback. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -1 line)			Patch
M	tests/language/language.status	View	1	2 chunks	+29 lines, -1 line	0 comments	Download
M	tests/language/language-leg.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/language/src/GetSetSyntaxTest.dart	View		1 chunk	+47 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://chromiumcodereview.appspot.com/9350016/diff/1/tests/language/language-leg.status File tests/language/language-leg.status (right): https://chromiumcodereview.appspot.com/9350016/diff/1/tests/language/language-leg.status#newcode142 tests/language/language-leg.status:142: GetSetSyntaxTest/none: Fail # Issue 1569 Please create a ...

8 years, 10 months ago (2012-02-07 12:13:19 UTC) #2

kasperl

8 years, 10 months ago (2012-02-07 12:28:33 UTC) #3

https://chromiumcodereview.appspot.com/9350016/diff/1/tests/language/language...
File tests/language/language-leg.status (right):

https://chromiumcodereview.appspot.com/9350016/diff/1/tests/language/language...
tests/language/language-leg.status:142: GetSetSyntaxTest/none: Fail # Issue 1569
On 2012/02/07 12:13:19, ahe wrote:
> Please create a separate issue for Leg or just remove the comment.

Removed the comment.

https://chromiumcodereview.appspot.com/9350016/diff/1/tests/language/language...
File tests/language/language.status (right):

https://chromiumcodereview.appspot.com/9350016/diff/1/tests/language/language...
tests/language/language.status:257: GetSetSyntaxTest/00: Fail # Issue 1569
On 2012/02/07 12:13:19, ahe wrote:
> Please create a separate issue for frog.

Done.

Expand Messages | Collapse Messages

Issue 9350016: Add test cases for issue 1569. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address review feedback. #

Messages