Issue 9349014: Fix NPE in parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9349014: Fix NPE in parser. (Closed)

Created:
8 years, 10 months ago by ahe

Modified:
8 years, 10 months ago

Reviewers:
Lasse Reichstein Nielsen, ngeoffray

CC:
reviews_dartlang.org, kasperl, floitsch, karlklose

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix NPE in parser. Committed: https://code.google.com/p/dart/source/detail?r=3993

Patch Set 2 : Address review comments #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	dart/frog/leg/scanner/parser.dart	View	1	1 chunk	+8 lines, -1 line	0 comments	Download
	M	dart/tests/language/src/SyntaxTest.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://chromiumcodereview.appspot.com/9349014/diff/1003/dart/frog/leg/scanner/parser.dart File dart/frog/leg/scanner/parser.dart (right): https://chromiumcodereview.appspot.com/9349014/diff/1003/dart/frog/leg/scanner/parser.dart#newcode320 dart/frog/leg/scanner/parser.dart:320: if (beginGroupToken.endGroup !== null) { Please add a ...

8 years, 10 months ago (2012-02-07 13:40:26 UTC) #2

ahe

8 years, 10 months ago (2012-02-07 14:24:47 UTC) #3

Thank you, Nicolas.

https://chromiumcodereview.appspot.com/9349014/diff/1003/dart/frog/leg/scanne...
File dart/frog/leg/scanner/parser.dart (right):

https://chromiumcodereview.appspot.com/9349014/diff/1003/dart/frog/leg/scanne...
dart/frog/leg/scanner/parser.dart:320: if (beginGroupToken.endGroup !== null) {
On 2012/02/07 13:40:27, ngeoffray wrote:
> Please add a comment that you're considering the following tokens as not being
> part of the type variables.

Done.

Expand Messages | Collapse Messages

Issue 9349014: Fix NPE in parser. (Closed)

Description

Patch Set 1 : changes #

Patch Set 2 : Address review comments #

Messages