Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 9348112: Make gen files more human-readable by using a string initializer (Closed)

Created:
8 years, 10 months ago by turnidge
Modified:
8 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Make gen files more human-readable by using a string initializer instead of an integer array initializer. For example, the initializer in builtin_gen.cc now looks something like this: const char Builtin::builtin_source_[] = // ----- bin/builtin.dart ----- "// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file\n" "// for details. All rights reserved. Use of this source code is governed by a\n" "// BSD-style license that can be found in the LICENSE file.\n" "\n" "#library(\"builtin\");\n" "#import(\"dart:nativewrappers\");\n" "#import(\"dart:coreimpl\");\n" "\n" "void print(arg) {\n" " _Logger._printString(arg.toString());\n" /* L10 */ "}\n" "\n" "void exit(int status) {\n" " if (status is !int) {\n" " throw new IllegalArgumentException(\"int status expected\");\n" " }\n" " _exit(status);\n" "}\n" "\n" "_exit(int status) native \"Exit\";\n" /* L20 */ "\n" "class _Logger {\n" " static void _printString(String s) native \"Logger_PrintString\";\n" "}\n" ; Committed: https://code.google.com/p/dart/source/detail?r=4280

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -22 lines) Patch
M runtime/bin/builtin_in.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/bin/io_in.cc View 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/tools/create_string_literal.py View 1 chunk +21 lines, -10 lines 0 comments Download
M runtime/vm/corelib_impl_in.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/corelib_in.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
turnidge
8 years, 10 months ago (2012-02-14 23:28:23 UTC) #1
siva
8 years, 10 months ago (2012-02-15 18:52:40 UTC) #2
LGTM

Is there any impact on the size of the dart VM library because of this?

Powered by Google App Engine
This is Rietveld 408576698