Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issue 9348050: Fix problem with socket input stream on MacOS when reading from tty. (Closed)

Created:
8 years, 10 months ago by Mads Ager (google)
Modified:
8 years, 10 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix problem with socket input stream on MacOS when reading from tty. This could cause an empty buffer to be added to an internal BufferList which violates our assumptions. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4027

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M runtime/bin/socket_stream_impl.dart View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
8 years, 10 months ago (2012-02-08 10:32:38 UTC) #1
Søren Gjesse
8 years, 10 months ago (2012-02-08 10:41:05 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698