Issue 9347032: Fix issue 1246

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9347032: Fix issue 1246 (Closed)

Created:
8 years, 10 months ago by hausner

Modified:
8 years, 10 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -7 lines)			Patch
M	runtime/vm/parser.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/scopes.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/scopes.cc	View		1 chunk	+7 lines, -5 lines	0 comments	Download
M	tests/language/src/ContinueTest.dart	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

regis

LGTM How about adding the example of the issue as a new test?

8 years, 10 months ago (2012-02-07 21:58:08 UTC) #2

hausner

8 years, 10 months ago (2012-02-07 23:29:25 UTC) #3

Added a test case to existing ContinueTest. Thanks for the review.