Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Issue 9347023: Add dartdoc comments to Dart testing infrastructure. (Closed)

Created:
8 years, 10 months ago by Bill Hesse
Modified:
8 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add dartdoc comments to Dart testing infrastructure. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4079

Patch Set 1 #

Total comments: 10

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -32 lines) Patch
M tools/testing/dart/test_runner.dart View 1 14 chunks +73 lines, -21 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 13 chunks +78 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bill Hesse
8 years, 10 months ago (2012-02-07 16:38:27 UTC) #1
Bob Nystrom
A couple of nits but otherwise this is fantastic. Thanks for doing this! LGTM. https://chromiumcodereview.appspot.com/9347023/diff/1/tools/testing/dart/test_runner.dart ...
8 years, 10 months ago (2012-02-07 18:41:24 UTC) #2
Mads Ager (google)
lgtm
8 years, 10 months ago (2012-02-08 07:40:46 UTC) #3
Bill Hesse
https://chromiumcodereview.appspot.com/9347023/diff/1/tools/testing/dart/test_runner.dart File tools/testing/dart/test_runner.dart (right): https://chromiumcodereview.appspot.com/9347023/diff/1/tools/testing/dart/test_runner.dart#newcode25 tools/testing/dart/test_runner.dart:25: * its output. Running a test involves starting a ...
8 years, 10 months ago (2012-02-09 15:47:39 UTC) #4
Bob Nystrom
8 years, 10 months ago (2012-02-09 21:23:47 UTC) #5
https://chromiumcodereview.appspot.com/9347023/diff/1/tools/testing/dart/test...
File tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/9347023/diff/1/tools/testing/dart/test...
tools/testing/dart/test_suite.dart:33: * Call the callback function onTest with
a [TestCase] argument for each
On 2012/02/09 15:47:39, Bill Hesse wrote:
> On 2012/02/07 18:41:24, Bob Nystrom wrote:
> > [onTest] and the other parameters mentioned.
> > 
> > You can reference parameter names with [] too.
> 
> How can we reference fields or functions of class B, in the comment for a
method
> of class A?  Is there a way to write this?

I believe [B.field] should do that. If not, it's a bug. :)

Powered by Google App Engine
This is Rietveld 408576698