Change file opening operation to set position at the end of the file when FileMode.APPEND is used.

Change file opening operation to set position at the end of the file when FileMode.APPEND is used.

Additionally, allow File.openOutputStream to take a FileMode enum (only FileMode.WRITE and FileMode.APPEND is allowed).
Committed: https://code.google.com/p/dart/source/detail?r=3984

[Mads Ager (google), 2012-02-07 08:37:31]

https://chromiumcodereview.appspot.com/9346015/diff/3001/runtime/bin/file.dart
File runtime/bin/file.dart (right):

https://chromiumcodereview.appspot.com/9346015/diff/3001/runtime/bin/file.dar...
runtime/bin/file.dart:109: * not truncated and that the position is set to the
end of the file.
that the -> the

https://chromiumcodereview.appspot.com/9346015/diff/3001/runtime/bin/file.dar...
runtime/bin/file.dart:132: InputStream openInputStream([FileMode mode]);
?

You want this to go on the openOutputStream, right?

https://chromiumcodereview.appspot.com/9346015/diff/3001/runtime/bin/file.dar...
runtime/bin/file.dart:141: * FileMode.WRITE: create the stream and truncate the
the underlying
the the -> the

https://chromiumcodereview.appspot.com/9346015/diff/3001/runtime/bin/file.dar...
runtime/bin/file.dart:144: * FileMode.APPEND: create the stream and set the
position at the end of
at the -> to the

https://chromiumcodereview.appspot.com/9346015/diff/3001/runtime/bin/file_imp...
File runtime/bin/file_impl.dart (right):

https://chromiumcodereview.appspot.com/9346015/diff/3001/runtime/bin/file_imp...
runtime/bin/file_impl.dart:595: _FileUtils.setPosition(id,
_FileUtils.length(id));
Please do this in the C++ code instead. Here you are turning what should be an
async operation into a sync operation for the setting of the position. The C++
code knows about the mode as well and can set the position as part of the open
call. That will happen on a separate thread and will not block the main dart
thread.

https://chromiumcodereview.appspot.com/9346015/diff/3001/runtime/bin/file_imp...
runtime/bin/file_impl.dart:622: _FileUtils.setPosition(id,
_FileUtils.length(id));
Ditto. This is actually fine because this is the sync version, but if open in
the C++ code takes care of it you don't need this.

[ricow1, 2012-02-07 09:16:22]

https://chromiumcodereview.appspot.com/9346015/diff/3001/runtime/bin/file.dart
File runtime/bin/file.dart (right):

https://chromiumcodereview.appspot.com/9346015/diff/3001/runtime/bin/file.dar...
runtime/bin/file.dart:109: * not truncated and that the position is set to the
end of the file.
On 2012/02/07 08:37:31, Mads Ager wrote:
> that the -> the

Done.

https://chromiumcodereview.appspot.com/9346015/diff/3001/runtime/bin/file.dar...
runtime/bin/file.dart:132: InputStream openInputStream([FileMode mode]);
On 2012/02/07 08:37:31, Mads Ager wrote:
> ?
> 
> You want this to go on the openOutputStream, right?

Done.

https://chromiumcodereview.appspot.com/9346015/diff/3001/runtime/bin/file.dar...
runtime/bin/file.dart:141: * FileMode.WRITE: create the stream and truncate the
the underlying
On 2012/02/07 08:37:31, Mads Ager wrote:
> the the -> the

Done.

https://chromiumcodereview.appspot.com/9346015/diff/3001/runtime/bin/file.dar...
runtime/bin/file.dart:144: * FileMode.APPEND: create the stream and set the
position at the end of
On 2012/02/07 08:37:31, Mads Ager wrote:
> at the -> to the

Done.

https://chromiumcodereview.appspot.com/9346015/diff/3001/runtime/bin/file_imp...
File runtime/bin/file_impl.dart (right):

https://chromiumcodereview.appspot.com/9346015/diff/3001/runtime/bin/file_imp...
runtime/bin/file_impl.dart:595: _FileUtils.setPosition(id,
_FileUtils.length(id));
On 2012/02/07 08:37:31, Mads Ager wrote:
> Please do this in the C++ code instead. Here you are turning what should be an
> async operation into a sync operation for the setting of the position. The C++
> code knows about the mode as well and can set the position as part of the open
> call. That will happen on a separate thread and will not block the main dart
> thread.
Done, I placed these in the platform specific files, let me know if you wan't me
to do something like:
if (file != NULL && mode == kAppend) {
  file->SetPosition(file->Length());
}
in File_Open in file.cc instead (it seems that we normally only do one platform
specific call per file.cc native method so I did the same)

https://chromiumcodereview.appspot.com/9346015/diff/3001/runtime/bin/file_imp...
runtime/bin/file_impl.dart:622: _FileUtils.setPosition(id,
_FileUtils.length(id));
On 2012/02/07 08:37:31, Mads Ager wrote:
> Ditto. This is actually fine because this is the sync version, but if open in
> the C++ code takes care of it you don't need this.

Done.

[Mads Ager (google), 2012-02-07 09:23:27]

LGTM!

https://chromiumcodereview.appspot.com/9346015/diff/3003/runtime/bin/file_lin...
File runtime/bin/file_linux.cc (right):

https://chromiumcodereview.appspot.com/9346015/diff/3003/runtime/bin/file_lin...
runtime/bin/file_linux.cc:121: ASSERT(position >= 0);
return NULL instead?