Fix http://dartbug.com/1133:

Fix http://dartbug.com/1133:
- Incrementally concat error messages to avoid hitting
  a maximum error message size.
Committed: https://code.google.com/p/dart/source/detail?r=4135

[hausner, 2012-02-07 01:00:55]

LGTM

https://chromiumcodereview.appspot.com/9334007/diff/3001/vm/parser.cc
File vm/parser.cc (right):

https://chromiumcodereview.appspot.com/9334007/diff/3001/vm/parser.cc#newcode...
vm/parser.cc:5169: static RawString* FormatMessageHelper(const char* format,
...) {
This could be called Stringf(format, ...)   and the above VStringf(format, args)
 ;-)

https://chromiumcodereview.appspot.com/9334007/diff/3001/vm/parser.cc#newcode...
vm/parser.cc:5197: msg_part = FormatMessageHelper(": %s: line %d pos %d: ",
Why not include the script name in this format string and use
script_url.ToCString() as it was before your change?

https://chromiumcodereview.appspot.com/9334007/diff/3001/vm/parser.cc#newcode...
vm/parser.cc:5203: message = String::Concat(message, msg_part);
These two calls can be factored out.

[Ivan Posva, 2012-02-07 04:09:55]

https://chromiumcodereview.appspot.com/9334007/diff/3001/vm/parser.cc
File vm/parser.cc (right):

https://chromiumcodereview.appspot.com/9334007/diff/3001/vm/parser.cc#newcode...
vm/parser.cc:5169: static RawString* FormatMessageHelper(const char* format,
...) {
On 2012/02/07 01:00:55, hausner wrote:
> This could be called Stringf(format, ...)   and the above VStringf(format,
args)
>  ;-)

Actually they might be generally useful factories on the String class. I will
move them to object.cc in a different CL.

https://chromiumcodereview.appspot.com/9334007/diff/3001/vm/parser.cc#newcode...
vm/parser.cc:5180: intptr_t token_index,
Bad indentation, will fix...

https://chromiumcodereview.appspot.com/9334007/diff/3001/vm/parser.cc#newcode...
vm/parser.cc:5197: msg_part = FormatMessageHelper(": %s: line %d pos %d: ",
On 2012/02/07 01:00:55, hausner wrote:
> Why not include the script name in this format string and use
> script_url.ToCString() as it was before your change?

Because the script_url could contain Unicode characters that we preserve the way
this is now.