Issue 9332008: Use production mode when running on debug VM.

Issue 9332008: Use production mode when running on debug VM. (Closed)

Created:
8 years, 10 months ago by ahe

Modified:
8 years, 10 months ago

Reviewers:
srdjan, kasperl

CC:
reviews_dartlang.org, Siggi Cherem (dart-lang), ngeoffray

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Use production mode when running on debug VM. Committed: https://code.google.com/p/dart/source/detail?r=3981

Patch Set 2 : Reenable slow tests #

Total comments: 2

Patch Set 3 : Address review comments #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -14 lines)			Patch
M	dart/frog/scripts/bootstrap/frog_bootstrap_wrapper.py	View	1 2	2 chunks	+11 lines, -3 lines	1 comment	Download
M	dart/frog/scripts/bootstrap/frog_wrapper.py	View		1 chunk	+5 lines, -6 lines	0 comments	Download
M	dart/utils/tests/css/css.status	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ahe

I think this is a good trade-off. We already run all our tests in developer ...

8 years, 10 months ago (2012-02-06 19:46:01 UTC) #2

kasperl

LGTM. https://chromiumcodereview.appspot.com/9332008/diff/2002/dart/frog/scripts/bootstrap/frog_bootstrap_wrapper.py File dart/frog/scripts/bootstrap/frog_bootstrap_wrapper.py (right): https://chromiumcodereview.appspot.com/9332008/diff/2002/dart/frog/scripts/bootstrap/frog_bootstrap_wrapper.py#newcode30 dart/frog/scripts/bootstrap/frog_bootstrap_wrapper.py:30: if 'Release' in product_dir: Maybe add a comment ...

8 years, 10 months ago (2012-02-07 09:07:55 UTC) #3

ahe

Thank you, Kasper! Cheers, Peter https://chromiumcodereview.appspot.com/9332008/diff/2002/dart/frog/scripts/bootstrap/frog_bootstrap_wrapper.py File dart/frog/scripts/bootstrap/frog_bootstrap_wrapper.py (right): https://chromiumcodereview.appspot.com/9332008/diff/2002/dart/frog/scripts/bootstrap/frog_bootstrap_wrapper.py#newcode30 dart/frog/scripts/bootstrap/frog_bootstrap_wrapper.py:30: if 'Release' in product_dir: ...

8 years, 10 months ago (2012-02-07 09:14:28 UTC) #4

srdjan

8 years, 10 months ago (2012-02-07 16:30:59 UTC) #5

https://chromiumcodereview.appspot.com/9332008/diff/5001/dart/frog/scripts/bo...
File dart/frog/scripts/bootstrap/frog_bootstrap_wrapper.py (right):

https://chromiumcodereview.appspot.com/9332008/diff/5001/dart/frog/scripts/bo...
dart/frog/scripts/bootstrap/frog_bootstrap_wrapper.py:35: vm_flags =
'--vm_flags=--enable_asserts --enable_type_checks'
Per specification, enabling type checks enables asserts as well, i.e.,
--enable_asserts does not hurt but is not needed.

Expand Messages | Collapse Messages