Use epoll for the event handler on Linux.

Use epoll for the event handler on Linux.

epoll is faster than poll and we avoid iterating all potential
file descriptors all the time.

R=sgjesse@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=3980

[Søren Gjesse, 2012-02-07 07:54:12]

lgtm

LGTM

Nice that the structure is almost exactly the same as before.

https://chromiumcodereview.appspot.com/9332003/diff/1/runtime/bin/eventhandle...
File runtime/bin/eventhandler_linux.cc (right):

https://chromiumcodereview.appspot.com/9332003/diff/1/runtime/bin/eventhandle...
runtime/bin/eventhandler_linux.cc:216: // Update epoll instance if needed.
Can't this be moved into the else block above and then we can get rid of the the
continue? It s only in the else block the event mask is changed as far as I can
see.

https://chromiumcodereview.appspot.com/9332003/diff/1/runtime/bin/eventhandle...
File runtime/bin/eventhandler_linux.h (right):

https://chromiumcodereview.appspot.com/9332003/diff/1/runtime/bin/eventhandle...
runtime/bin/eventhandler_linux.h:115: int epoll_fd;
Missing trailing underscore.

[Mads Ager (google), 2012-02-07 08:09:34]

https://chromiumcodereview.appspot.com/9332003/diff/1/runtime/bin/eventhandle...
File runtime/bin/eventhandler_linux.cc (right):

https://chromiumcodereview.appspot.com/9332003/diff/1/runtime/bin/eventhandle...
runtime/bin/eventhandler_linux.cc:216: // Update epoll instance if needed.
On 2012/02/07 07:54:12, Søren Gjesse wrote:
> Can't this be moved into the else block above and then we can get rid of the
the
> continue? It s only in the else block the event mask is changed as far as I
can
> see.

Closing for read and closing for write also has an effect on the events that we
poll for. The 'continue' is not nice. I have explicitly put the
UpdateEpollInstance calls in the branches where it is needed and removed the
'continue'.

https://chromiumcodereview.appspot.com/9332003/diff/1/runtime/bin/eventhandle...
File runtime/bin/eventhandler_linux.h (right):

https://chromiumcodereview.appspot.com/9332003/diff/1/runtime/bin/eventhandle...
runtime/bin/eventhandler_linux.h:115: int epoll_fd;
On 2012/02/07 07:54:12, Søren Gjesse wrote:
> Missing trailing underscore.

Done.