Update co19-frog.status

Update co19-frog.status

Committed: https://code.google.com/p/dart/source/detail?r=3929

[ahe, 2012-02-05 14:19:06]

I have no idea what is going on. I'll investigate further.

[ahe, 2012-02-05 14:19:20]

TBR

[ahe, 2012-02-05 14:54:32]

This is related to --checked option of test.dart.

In dart/tools/testing/dart/test_suite.dart, we have this:

     } else if (contents.contains("@dynamic-type-error") &&
               configuration['checked']) {
      isNegative = true;
    }

This means that these tests, which all contain the keyword
"@dynamic-type-error", are marked as negative when --checked is passed to
test.dart.

In dart/frog/scripts/buildbot_annotated_steps.py, we have this:

  if mode == 'debug':
    flags = ['--checked']

In dart/frog/presubmit.py, we have this:

  test_cmd = ['../tools/test_wrapper.py', '--report', '--timeout=30',
              '--progress=color', '--mode=release', '--checked']

These tests did not fail presubmit.py, nor did they fail on the build bot
frogsh-linux-debug. This is exactly the places where --checked are passed to
test.dart making these tests negative.

On the other hand, the build bot frogsh-linux-release does not pass the
--checked option to test.dart, so here the tests are failing (as they are not
perceived as negative tests in this configuration).

[ahe, 2012-02-05 15:53:08]

I'm following up with https://chromiumcodereview.appspot.com/9310113 to clean
this up.

[kasperl, 2012-02-06 11:25:18]

LGTM. Thanks for cleaning it up (later).