Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 9325062: Fix flakiness of SocketCloseTest by waiting for all close events. (Closed)

Created:
8 years, 10 months ago by Mads Ager (google)
Modified:
8 years, 10 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix flakiness of SocketCloseTest by waiting for all close events. The assumption that all close events are delivered before the server shutdown message is received is false. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3933

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M tests/standalone/src/SocketCloseTest.dart View 2 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
8 years, 10 months ago (2012-02-06 11:24:46 UTC) #1
Søren Gjesse
8 years, 10 months ago (2012-02-06 11:26:38 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698