Issue 9325033: Run co19 language tests on leg.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9325033: Run co19 language tests on leg. (Closed)

Created:
8 years, 10 months ago by ahe

Modified:
8 years, 10 months ago

Reviewers:
ngeoffray, kasperl

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen, floitsch, karlklose, ngeoffray

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Run co19 language tests on leg. Committed: https://code.google.com/p/dart/source/detail?r=3928

Patch Set 1 #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+335 lines, -17 lines)			Patch
M	dart/frog/leg/resolver.dart	View	5 chunks	+11 lines, -15 lines	0 comments	Download
M	dart/frog/leg/ssa/builder.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	dart/tests/co19/co19-frog.status	View	1 chunk	+321 lines, -1 line	2 comments	Download
M	dart/tools/testing/dart/test_suite.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://chromiumcodereview.appspot.com/9325033/diff/1/dart/tests/co19/co19-frog.status File dart/tests/co19/co19-frog.status (right): https://chromiumcodereview.appspot.com/9325033/diff/1/dart/tests/co19/co19-frog.status#newcode10 dart/tests/co19/co19-frog.status:10: [ $component == leg ] Should we have ...

8 years, 10 months ago (2012-02-06 12:05:50 UTC) #3

ahe

8 years, 10 months ago (2012-02-06 12:36:01 UTC) #4

Hi Kasper and Nicolas,

Thank you for going over this.

Cheers,
Peter

https://chromiumcodereview.appspot.com/9325033/diff/1/dart/tests/co19/co19-fr...
File dart/tests/co19/co19-frog.status (right):

https://chromiumcodereview.appspot.com/9325033/diff/1/dart/tests/co19/co19-fr...
dart/tests/co19/co19-frog.status:10: [ $component == leg ]
On 2012/02/06 12:05:50, ngeoffray wrote:
> Should we have a special file for that? Like we have for language and corelib?
> Having the file named frog is not consistent.

I'll send out a follow-up CL shortly to make this change.

Expand Messages | Collapse Messages