Issue 9325030: Mark test as flaky

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9325030: Mark test as flaky (Closed)

Created:
8 years, 10 months ago by ahe

Modified:
8 years, 10 months ago

Reviewers:
kasperl, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Mark test as flaky Committed: https://code.google.com/p/dart/source/detail?r=3908

Patch Set 1 #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	dart/tests/co19/co19-runtime.status	View		2 chunks	+1 line, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with comment. -Ivan https://chromiumcodereview.appspot.com/9325030/diff/1/dart/tests/co19/co19-runtime.status File dart/tests/co19/co19-runtime.status (right): https://chromiumcodereview.appspot.com/9325030/diff/1/dart/tests/co19/co19-runtime.status#newcode235 dart/tests/co19/co19-runtime.status:235: LibTest/core/Stopwatch/elapsed_A01_t02: Skip # Flaky test. ...

8 years, 10 months ago (2012-02-03 16:46:42 UTC) #2

ahe

8 years, 10 months ago (2012-02-03 17:20:40 UTC) #3

https://chromiumcodereview.appspot.com/9325030/diff/1/dart/tests/co19/co19-ru...
File dart/tests/co19/co19-runtime.status (right):

https://chromiumcodereview.appspot.com/9325030/diff/1/dart/tests/co19/co19-ru...
dart/tests/co19/co19-runtime.status:235: LibTest/core/Stopwatch/elapsed_A01_t02:
Skip # Flaky test.
On 2012/02/03 16:46:42, Ivan Posva wrote:
> Please mark flaky tests as "Pass,Fail". This way we at least catch crashes.

I'll leave it to your team to make adjustments to the status file.

My goal is to make the build bots green with as little use of skip as possible.
However, once I have failed getting the status right for a particular test, I
play it safe and use skip. This is because I'm trying to maximize my chances
that the 45 minute build bots remain green.

Expand Messages | Collapse Messages