Fix for issue 1480: analyze a method even if it does not have a body, and do not try to evaluate ...

Fix for issue 1480: analyze a method even if it does not have a body, and do not try to evaluate a call if it does not have the right number of arguments.
Committed: https://code.google.com/p/dart/source/detail?r=3937

[kasperl, 2012-02-03 15:39:20]

LGTM.

https://chromiumcodereview.appspot.com/9325029/diff/1/dart/frog/analyze.dart
File dart/frog/analyze.dart (right):

https://chromiumcodereview.appspot.com/9325029/diff/1/dart/frog/analyze.dart#...
dart/frog/analyze.dart:51: final declaredInitializers =
method.definition.dynamic.initializers;
Add a comment here that explains how this is dealt with. Explain that your
changing the behavior of visitCallExpression to realize when you're in the
middle of visiting an initializer expression (alternatively you could add
another visitor but that's probably overkill).

https://chromiumcodereview.appspot.com/9325029/diff/1/dart/frog/analyze.dart#...
dart/frog/analyze.dart:56: if (init is CallExpression) {
How bad would it be to add an optional parameter to visitCallExpression
[inInitializer=false] and call that visit function from here with inInitializer:
true? That way you wouldn't need to add extra state to this visitor.

https://chromiumcodereview.appspot.com/9325029/diff/1/dart/frog/analyze.dart#...
dart/frog/analyze.dart:57: init.visit(this);;
;; -> ;

https://chromiumcodereview.appspot.com/9325029/diff/1/dart/frog/analyze.dart#...
dart/frog/analyze.dart:411: analyzeThisOrSuperConstructorCall(CallExpression
node,
analyzeInitializerConstructorCall instead? In this context, they are both
constructor calls.

https://chromiumcodereview.appspot.com/9325029/diff/1/dart/frog/analyze.dart#...
dart/frog/analyze.dart:423: world.warning('cannot find "$name"', node.span);
How does this look if name is the empty string? Maybe you should pass in null
for name in that case instead and deal with it?

https://chromiumcodereview.appspot.com/9325029/diff/1/dart/frog/gen.dart
File dart/frog/gen.dart (right):

https://chromiumcodereview.appspot.com/9325029/diff/1/dart/frog/gen.dart#newc...
dart/frog/gen.dart:1003: // Not enough argument, we'll get an error later.
argument -> arguments

https://chromiumcodereview.appspot.com/9325029/diff/1/dart/tests/language/src...
File dart/tests/language/src/BodyLessConstructorWrongArgNegativeTest.dart
(right):

https://chromiumcodereview.appspot.com/9325029/diff/1/dart/tests/language/src...
dart/tests/language/src/BodyLessConstructorWrongArgNegativeTest.dart:15: const
C(var x): super(); // call super construtor with wrong arg count
construtor -> constructor

[ngeoffray, 2012-02-06 11:50:30]

Thanks Kasper,

https://chromiumcodereview.appspot.com/9325029/diff/1/dart/frog/analyze.dart
File dart/frog/analyze.dart (right):

https://chromiumcodereview.appspot.com/9325029/diff/1/dart/frog/analyze.dart#...
dart/frog/analyze.dart:51: final declaredInitializers =
method.definition.dynamic.initializers;
On 2012/02/03 15:39:20, kasperl wrote:
> Add a comment here that explains how this is dealt with. Explain that your
> changing the behavior of visitCallExpression to realize when you're in the
> middle of visiting an initializer expression (alternatively you could add
> another visitor but that's probably overkill).

Done.

https://chromiumcodereview.appspot.com/9325029/diff/1/dart/frog/analyze.dart#...
dart/frog/analyze.dart:56: if (init is CallExpression) {
On 2012/02/03 15:39:20, kasperl wrote:
> How bad would it be to add an optional parameter to visitCallExpression
> [inInitializer=false] and call that visit function from here with
inInitializer:
> true? That way you wouldn't need to add extra state to this visitor.

Done.

https://chromiumcodereview.appspot.com/9325029/diff/1/dart/frog/analyze.dart#...
dart/frog/analyze.dart:57: init.visit(this);;
On 2012/02/03 15:39:20, kasperl wrote:
> ;; -> ;

Done.

https://chromiumcodereview.appspot.com/9325029/diff/1/dart/frog/analyze.dart#...
dart/frog/analyze.dart:411: analyzeThisOrSuperConstructorCall(CallExpression
node,
On 2012/02/03 15:39:20, kasperl wrote:
> analyzeInitializerConstructorCall instead? In this context, they are both
> constructor calls.

Done.

https://chromiumcodereview.appspot.com/9325029/diff/1/dart/frog/analyze.dart#...
dart/frog/analyze.dart:423: world.warning('cannot find "$name"', node.span);
On 2012/02/03 15:39:20, kasperl wrote:
> How does this look if name is the empty string? Maybe you should pass in null
> for name in that case instead and deal with it?

Done.

https://chromiumcodereview.appspot.com/9325029/diff/1/dart/frog/gen.dart
File dart/frog/gen.dart (right):

https://chromiumcodereview.appspot.com/9325029/diff/1/dart/frog/gen.dart#newc...
dart/frog/gen.dart:1003: // Not enough argument, we'll get an error later.
On 2012/02/03 15:39:20, kasperl wrote:
> argument -> arguments

Done.

https://chromiumcodereview.appspot.com/9325029/diff/1/dart/tests/language/src...
File dart/tests/language/src/BodyLessConstructorWrongArgNegativeTest.dart
(right):

https://chromiumcodereview.appspot.com/9325029/diff/1/dart/tests/language/src...
dart/tests/language/src/BodyLessConstructorWrongArgNegativeTest.dart:15: const
C(var x): super(); // call super construtor with wrong arg count
On 2012/02/03 15:39:20, kasperl wrote:
> construtor -> constructor

Done.