Issue 9325023: Support noSuchMethod for methods that take named parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9325023: Support noSuchMethod for methods that take named parameters. (Closed)

Created:
8 years, 10 months ago by ngeoffray

Modified:
8 years, 10 months ago

Reviewers:
Lasse Reichstein Nielsen, floitsch

CC:
reviews_dartlang.org, karlklose, ahe, kasperl

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Support noSuchMethod for methods that take named parameters. Committed: https://code.google.com/p/dart/source/detail?r=3901

Patch Set 2 : '' #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -9 lines)			Patch
	M	frog/leg/emitter.dart	View		2 chunks	+7 lines, -7 lines	2 comments	Download
	M	tests/language/language-leg.status	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://chromiumcodereview.appspot.com/9325023/diff/2002/frog/leg/emitter.dart File frog/leg/emitter.dart (right): https://chromiumcodereview.appspot.com/9325023/diff/2002/frog/leg/emitter.dart#newcode312 frog/leg/emitter.dart:312: buffer.add(" return this.$noSuchMethodName('$methodName', [$args]);\n"); in the current form ...

8 years, 10 months ago (2012-02-03 13:24:26 UTC) #2

ngeoffray

8 years, 10 months ago (2012-02-03 13:42:27 UTC) #3

https://chromiumcodereview.appspot.com/9325023/diff/2002/frog/leg/emitter.dart
File frog/leg/emitter.dart (right):

https://chromiumcodereview.appspot.com/9325023/diff/2002/frog/leg/emitter.dar...
frog/leg/emitter.dart:312: buffer.add("  return
this.$noSuchMethodName('$methodName', [$args]);\n");
On 2012/02/03 13:24:26, floitsch wrote:
> in the current form NSM is useless since you wouldn't know what named argument
> got what value. correct?

Correct, we need to implement a mirror thingy...

Expand Messages | Collapse Messages

Issue 9325023: Support noSuchMethod for methods that take named parameters. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages