Issue 9325002: Fix windows performance tests.

Issue 9325002: Fix windows performance tests. (Closed)

Created:
8 years, 10 months ago by Emily Fortuna

Modified:
8 years, 10 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix windows performance tests. Committed: https://code.google.com/p/dart/source/detail?r=3865

Patch Set 2 : '' #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -6 lines)			Patch
M	client/tests/client/samples/smoketest/dartWebBase_tests.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	frog/scripts/buildbot_annotated_steps.py	View	1	1 chunk	+5 lines, -4 lines	1 comment	Download
M	tools/testing/perf_testing/create_graph.py	View	1	2 chunks	+8 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

https://chromiumcodereview.appspot.com/9325002/diff/4/tools/testing/perf_testing/create_graph.py File tools/testing/perf_testing/create_graph.py (right): https://chromiumcodereview.appspot.com/9325002/diff/4/tools/testing/perf_testing/create_graph.py#newcode96 tools/testing/perf_testing/create_graph.py:96: def on_rm_error(func, path, exc_info): On windows, the output directory ...

8 years, 10 months ago (2012-02-02 18:24:09 UTC) #1

Siggi Cherem (dart-lang)

lgtm https://chromiumcodereview.appspot.com/9325002/diff/4/tools/testing/perf_testing/create_graph.py File tools/testing/perf_testing/create_graph.py (right): https://chromiumcodereview.appspot.com/9325002/diff/4/tools/testing/perf_testing/create_graph.py#newcode96 tools/testing/perf_testing/create_graph.py:96: def on_rm_error(func, path, exc_info): On 2012/02/02 18:24:09, Emily ...

8 years, 10 months ago (2012-02-02 18:29:58 UTC) #2

Emily Fortuna

Please take another look to be sure -- I added the buildbot_annotated_steps.py change to this ...

8 years, 10 months ago (2012-02-02 18:51:00 UTC) #3

Siggi Cherem (dart-lang)

8 years, 10 months ago (2012-02-02 19:22:16 UTC) #4

https://chromiumcodereview.appspot.com/9325002/diff/3001/frog/scripts/buildbo...
File frog/scripts/buildbot_annotated_steps.py (right):

https://chromiumcodereview.appspot.com/9325002/diff/3001/frog/scripts/buildbo...
frog/scripts/buildbot_annotated_steps.py:121: if system == 'windows':
!= instead of == ?

https://chromiumcodereview.appspot.com/9325002/diff/3001/tools/testing/perf_t...
File tools/testing/perf_testing/create_graph.py (right):

https://chromiumcodereview.appspot.com/9325002/diff/3001/tools/testing/perf_t...
tools/testing/perf_testing/create_graph.py:110:
utils.GetBuildRoot(utils.GuessOS(), 'release', 'ia32')), onerror=on_rm_error)
80 col

Expand Messages | Collapse Messages