Issue 9323077: Optimize special cases in utf8 and utf16 where input can be copied to output.

Issue 9323077: Optimize special cases in utf8 and utf16 where input can be copied to output. (Closed)

Created:
8 years, 10 months ago by dcarlson

Modified:
8 years, 10 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Optimize special cases in utf8 and utf16 where input can be copied to output. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3974

Patch Set 2 : Optimize special cases in utf8 and utf16 where input can be copied to output. #

Total comments: 4

Patch Set 3 : respond to comments, move throw up a little, fix unit test types. #

Total comments: 4

Patch Set 4 : corrections resulting from comments. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+130 lines, -94 lines)			Patch
M	utils/string_encoding/unicode_core.dart	View	1 2 3	5 chunks	+44 lines, -25 lines	0 comments	Download
M	utils/string_encoding/utf8_impl.dart	View	1 2 3	1 chunk	+85 lines, -68 lines	0 comments	Download
M	utils/tests/string_encoding/unicode_tests.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://chromiumcodereview.appspot.com/9323077/diff/2001/utils/string_encoding/unicode_core.dart File utils/string_encoding/unicode_core.dart (right): https://chromiumcodereview.appspot.com/9323077/diff/2001/utils/string_encoding/unicode_core.dart#newcode165 utils/string_encoding/unicode_core.dart:165: bool hasReplacements = false; See comment in other ...

8 years, 10 months ago (2012-02-06 15:45:44 UTC) #2

dcarlson

I made some additional slight modifications (corrected the type on a unit test expect, and ...

8 years, 10 months ago (2012-02-06 22:11:29 UTC) #3

Søren Gjesse

lgtm https://chromiumcodereview.appspot.com/9323077/diff/6001/utils/string_encoding/unicode_core.dart File utils/string_encoding/unicode_core.dart (right): https://chromiumcodereview.appspot.com/9323077/diff/6001/utils/string_encoding/unicode_core.dart#newcode177 utils/string_encoding/unicode_core.dart:177: // If the string calls for replacements, but ...

8 years, 10 months ago (2012-02-06 22:13:29 UTC) #4

dcarlson

8 years, 10 months ago (2012-02-13 16:37:50 UTC) #5

thought these were already published. Sorry.

https://chromiumcodereview.appspot.com/9323077/diff/6001/utils/string_encodin...
File utils/string_encoding/unicode_core.dart (right):

https://chromiumcodereview.appspot.com/9323077/diff/6001/utils/string_encodin...
utils/string_encoding/unicode_core.dart:177: // If the string calls for
replacements, but we the method is called
On 2012/02/06 22:13:29, Søren Gjesse wrote:
> Remove 'we' in 'but we the'

weird typo -- corrected to "when"

https://chromiumcodereview.appspot.com/9323077/diff/6001/utils/string_encodin...
File utils/string_encoding/utf8_impl.dart (right):

https://chromiumcodereview.appspot.com/9323077/diff/6001/utils/string_encodin...
utils/string_encoding/utf8_impl.dart:215: // If the string calls for
replacements, but we the method is called
On 2012/02/06 22:13:29, Søren Gjesse wrote:
> ditto.

Done.

Expand Messages | Collapse Messages