Issue 9323032: Update win32 checked co19 status

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9323032: Update win32 checked co19 status (Closed)

Created:
8 years, 10 months ago by ahe

Modified:
8 years, 10 months ago

Reviewers:
kasperl, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Update win32 checked co19 status Committed: https://code.google.com/p/dart/source/detail?r=3907

Patch Set 1 #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	dart/tests/co19/co19-runtime.status	View		1 chunk	+4 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -ip https://chromiumcodereview.appspot.com/9323032/diff/1/dart/tests/co19/co19-runtime.status File dart/tests/co19/co19-runtime.status (right): https://chromiumcodereview.appspot.com/9323032/diff/1/dart/tests/co19/co19-runtime.status#newcode126 dart/tests/co19/co19-runtime.status:126: LibTest/core/AssertionError/url_A01_t01: Fail These really only fail on ...

8 years, 10 months ago (2012-02-03 16:51:31 UTC) #2

ahe

8 years, 10 months ago (2012-02-03 16:52:51 UTC) #3

https://chromiumcodereview.appspot.com/9323032/diff/1/dart/tests/co19/co19-ru...
File dart/tests/co19/co19-runtime.status (right):

https://chromiumcodereview.appspot.com/9323032/diff/1/dart/tests/co19/co19-ru...
dart/tests/co19/co19-runtime.status:126:
LibTest/core/AssertionError/url_A01_t01: Fail
On 2012/02/03 16:51:31, Ivan Posva wrote:
> These really only fail on Windows in checked mode? Not sure what to make of
it.

I suspect that they check that uri's only use forward slashes.

Expand Messages | Collapse Messages