Issue 9323029: Fix error in standalone/StatusFileParserTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9323029: Fix error in standalone/StatusFileParserTest. (Closed)

Created:
8 years, 10 months ago by Bill Hesse

Modified:
8 years, 10 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix error in standalone/StatusFileParserTest. BUG= TEST=standalone/StatusFileParserTest Committed: https://code.google.com/p/dart/source/detail?r=3887

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change name of getFile. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	tests/standalone/src/StatusFileParserTest.dart	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ricow1

8 years, 10 months ago (2012-02-03 10:11:51 UTC) #2

LGTM

http://codereview.chromium.org/9323029/diff/1/tests/standalone/src/StatusFile...
File tests/standalone/src/StatusFileParserTest.dart (right):

http://codereview.chromium.org/9323029/diff/1/tests/standalone/src/StatusFile...
tests/standalone/src/StatusFileParserTest.dart:36: File file = new
File(getFile(filePath));
how about returning a File from getFile to actually do what the name of the
method says?

Expand Messages | Collapse Messages