Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 932273005: Support "--machine" flag. Fix #164. (Closed)

Created:
5 years, 10 months ago by Bob Nystrom
Modified:
5 years, 10 months ago
Reviewers:
pquitslund
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart_style.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support "--machine" flag. Fix #164. BUG=https://github.com/dart-lang/dart_style/issues/164 R=pquitslund@google.com Committed: 29009a21c28cb8713a4bf30eb08e60574b0272f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -68 lines) Patch
M CHANGELOG.md View 1 chunk +1 line, -0 lines 0 comments Download
M bin/format.dart View 3 chunks +41 lines, -21 lines 0 comments Download
A lib/src/formatter_options.dart View 1 chunk +114 lines, -0 lines 0 comments Download
M lib/src/io.dart View 3 chunks +13 lines, -36 lines 0 comments Download
M test/command_line_test.dart View 5 chunks +48 lines, -3 lines 0 comments Download
M test/io_test.dart View 9 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bob Nystrom
This outputs pretty much the same thing as the old formatter: one JSON map per ...
5 years, 10 months ago (2015-02-19 19:17:16 UTC) #2
pquitslund
LGTM!
5 years, 10 months ago (2015-02-19 22:24:38 UTC) #3
Bob Nystrom
5 years, 10 months ago (2015-02-20 00:44:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
29009a21c28cb8713a4bf30eb08e60574b0272f2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698