Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 9319001: Integrate VM IO libraries and search box into apidoc. (Closed)

Created:
8 years, 10 months ago by Bob Nystrom
Modified:
8 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Integrate VM IO libraries and search box into apidoc. Committed: https://code.google.com/p/dart/source/detail?r=3766

Patch Set 1 #

Total comments: 8

Patch Set 2 : Rebase. #

Patch Set 3 : Review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -39 lines) Patch
M utils/apidoc/.gitignore View 1 chunk +2 lines, -1 line 0 comments Download
M utils/apidoc/apidoc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M utils/apidoc/apidoc.dart View 3 chunks +29 lines, -0 lines 0 comments Download
M utils/dartdoc/dartdoc.dart View 1 22 chunks +67 lines, -38 lines 0 comments Download
M utils/dartdoc/static/styles.css View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
You can take a look at them at: www/~rnystrom/docs
8 years, 10 months ago (2012-01-31 22:30:27 UTC) #1
nweiz
lgtm https://chromiumcodereview.appspot.com/9319001/diff/1/utils/apidoc/apidoc File utils/apidoc/apidoc (right): https://chromiumcodereview.appspot.com/9319001/diff/1/utils/apidoc/apidoc#newcode43 utils/apidoc/apidoc:43: # sources until runtime/bin/ directly instead of relying ...
8 years, 10 months ago (2012-01-31 23:35:33 UTC) #2
Bob Nystrom
8 years, 10 months ago (2012-02-01 00:35:29 UTC) #3
Tanks!

https://chromiumcodereview.appspot.com/9319001/diff/1/utils/apidoc/apidoc
File utils/apidoc/apidoc (right):

https://chromiumcodereview.appspot.com/9319001/diff/1/utils/apidoc/apidoc#new...
utils/apidoc/apidoc:43: # sources until runtime/bin/ directly instead of relying
on this.
On 2012/01/31 23:35:33, nweiz wrote:
> s/until/under/?

Done.

https://chromiumcodereview.appspot.com/9319001/diff/1/utils/apidoc/apidoc#new...
utils/apidoc/apidoc:44: grep "'*.dart'" ../../runtime/bin/io_sources.gypi | sed
s/\',//g | sed s,\',../../runtime/bin/,g | xargs cat > io_libs.dart
On 2012/01/31 23:35:33, nweiz wrote:
> Line length

Done.

https://chromiumcodereview.appspot.com/9319001/diff/1/utils/apidoc/apidoc.dart
File utils/apidoc/apidoc.dart (right):

https://chromiumcodereview.appspot.com/9319001/diff/1/utils/apidoc/apidoc.dar...
utils/apidoc/apidoc.dart:112: // want it in the docs.
On 2012/01/31 23:35:33, nweiz wrote:
> I dunno if this is even that hackish. It makes sense to me that a
> library-specific documentor would have some library-specific logic like this.
> 
> It might be nicer to have this in some sort of in-code annotation, I suppose.

Yeah, it's kind of hairy because if stuff in the io libs actually referenced
types or members in "dart:nativewrappers" then we would still be linking to
those things even though that library doesn't exist in the navigation.

https://chromiumcodereview.appspot.com/9319001/diff/1/utils/dartdoc/dartdoc.dart
File utils/dartdoc/dartdoc.dart (right):

https://chromiumcodereview.appspot.com/9319001/diff/1/utils/dartdoc/dartdoc.d...
utils/dartdoc/dartdoc.dart:169: void document(String entrypoint) {
On 2012/01/31 23:35:33, nweiz wrote:
> Is this the new style? Is there now any case in which you would omit the
return
> type for a function?

I generally try to annotate public methods. Private methods I don't usually
worry about. I don't think you *need* to annotate all return types for all
public methods but I did here, uh, just 'cause I guess.

Powered by Google App Engine
This is Rietveld 408576698