Issue 9318013: Fix build break in dartdoc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9318013: Fix build break in dartdoc. (Closed)

Created:
8 years, 10 months ago by Bob Nystrom

Modified:
8 years, 10 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix build break in dartdoc. Committed: https://code.google.com/p/dart/source/detail?r=3763

Patch Set 2 : Review. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -115 lines)			Patch
M	utils/dartdoc/dartdoc.dart	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
D	utils/dartdoc/files.dart	View		1 chunk	+0 lines, -80 lines	0 comments	Download
M	utils/tests/dartdoc/src/dartdoc_tests.dart	View		6 chunks	+42 lines, -34 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm lgtm https://chromiumcodereview.appspot.com/9318013/diff/1/utils/dartdoc/dartdoc.dart File utils/dartdoc/dartdoc.dart (right): https://chromiumcodereview.appspot.com/9318013/diff/1/utils/dartdoc/dartdoc.dart#newcode907 utils/dartdoc/dartdoc.dart:907: typeUrl(Type type) { Why was the type ...

8 years, 10 months ago (2012-01-31 23:31:25 UTC) #2

Bob Nystrom

8 years, 10 months ago (2012-01-31 23:32:38 UTC) #3

Thanks!

https://chromiumcodereview.appspot.com/9318013/diff/1/utils/dartdoc/dartdoc.dart
File utils/dartdoc/dartdoc.dart (right):

https://chromiumcodereview.appspot.com/9318013/diff/1/utils/dartdoc/dartdoc.d...
utils/dartdoc/dartdoc.dart:907: typeUrl(Type type) {
On 2012/01/31 23:31:25, nweiz wrote:
> Why was the type removed?

Copy/paste error. I'll fix.

https://chromiumcodereview.appspot.com/9318013/diff/1/utils/dartdoc/dartdoc.d...
utils/dartdoc/dartdoc.dart:916: memberUrl(Member member) {
On 2012/01/31 23:31:25, nweiz wrote:
> See above.

Ditto.

Expand Messages | Collapse Messages

Issue 9318013: Fix build break in dartdoc. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Review. #

Messages