Issue 9317099: Improve repoorting of NoSuchMethod:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9317099: Improve repoorting of NoSuchMethod: (Closed)

Created:
8 years, 10 months ago by srdjan

Modified:
8 years, 10 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Improve repoorting of NoSuchMethod: NoSuchMethodException: incorrect number of arguments passed to method named 'foo' Receiver: Instance of 'A' Tried calling: foo(5, 6, 7) Found: foo(b, c) Committed: https://code.google.com/p/dart/source/detail?r=3960

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -24 lines)			Patch
	M	corelib/src/exceptions.dart	View	1 2 3	2 chunks	+20 lines, -6 lines	0 comments	Download
	M	runtime/lib/object.cc	View	1 2	1 chunk	+6 lines, -18 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM. Thank you! Cheers, Peter https://chromiumcodereview.appspot.com/9317099/diff/4/corelib/src/exceptions.dart File corelib/src/exceptions.dart (right): https://chromiumcodereview.appspot.com/9317099/diff/4/corelib/src/exceptions.dart#newcode53 corelib/src/exceptions.dart:53: "function name: '$_functionName' arguments: ...

8 years, 10 months ago (2012-02-06 10:04:10 UTC) #2

srdjan

https://chromiumcodereview.appspot.com/9317099/diff/4/corelib/src/exceptions.dart File corelib/src/exceptions.dart (right): https://chromiumcodereview.appspot.com/9317099/diff/4/corelib/src/exceptions.dart#newcode53 corelib/src/exceptions.dart:53: "function name: '$_functionName' arguments: [$sb]"; On 2012/02/06 10:04:10, ahe ...

8 years, 10 months ago (2012-02-06 17:53:08 UTC) #3

Still LGTM!

Expand Messages | Collapse Messages