Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 9317054: Fix for issue r1469: DartVM appears to not GC closure reachable memory properly (Closed)

Created:
8 years, 10 months ago by srdjan
Modified:
8 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix for issue r1469: DartVM appears to not GC closure reachable memory properly (The issue was diagnosed and solved by Siva) The problem appears when allocating large arrays that are stored in a context. We allocate large arrays directly in the old space. The context in which these arrays are stored is in the new space. When we do an old gen GC we were not first scavenging the new space. As a result the large arrays still remained when we did the old-gen GC, resulting in OOM. The fix is to do both a new gen scavenge and an old gen mark-sweep when we run out of space in the old gen. Committed: https://code.google.com/p/dart/source/detail?r=3856

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M runtime/vm/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
A tests/language/src/GCTest.dart View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
srdjan
8 years, 10 months ago (2012-02-02 17:38:56 UTC) #1
siva
8 years, 10 months ago (2012-02-02 17:41:02 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698