Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 9317040: Don't check for Member. (Closed)

Created:
8 years, 10 months ago by Bob Nystrom
Modified:
8 years, 10 months ago
Reviewers:
nweiz, Jacob
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't check for Member. Fixes broken correspondences between html and htmlimpl. That in turn fixes a bunch of missing MDN docs. Committed: https://code.google.com/p/dart/source/detail?r=3813

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M utils/apidoc/html_diff.dart View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bob Nystrom
Jacob, this addresses your email about why html.Element is missing a bunch of stuff.
8 years, 10 months ago (2012-02-01 21:36:13 UTC) #1
Jacob
lgtm
8 years, 10 months ago (2012-02-01 22:10:08 UTC) #2
nweiz
Does this mean we're now printing warnings like "No DOM type corresponds to ChildrenElementList"?
8 years, 10 months ago (2012-02-01 22:41:57 UTC) #3
Bob Nystrom
8 years, 10 months ago (2012-02-02 01:01:29 UTC) #4
On 2012/02/01 22:41:57, nweiz wrote:
> Does this mean we're now printing warnings like "No DOM type corresponds to
> ChildrenElementList"?

There are a few warnings:

Warning: no dart:dom type matches dart:htmlimpl FlagsWrappingImplementation
Warning: no dart:dom type matches dart:htmlimpl
NavigatorUserMediaErrorWrappingImplementation
Warning: no dart:dom type matches dart:htmlimpl
NavigatorUserMediaSuccessCallbackWrappingImplementation
Warning: no member Window.getComputedStyle
Warning: no member Window.getComputedStyle
Warning: no member OverflowEvent.initOverflowEvent

But much fewer than there were before were I think every correspondence between
html and htmlimpl was broken.

Powered by Google App Engine
This is Rietveld 408576698