Issue 9317021: Fix leg build, removed positive check as they fail in leg. The positive test must be somewhere else.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9317021: Fix leg build, removed positive check as they fail in leg. The positive test must be somewhere else. (Closed)

Created:
8 years, 10 months ago by srdjan

Modified:
8 years, 8 months ago

Reviewers:
kasperl, hausner

CC:
reviews_dartlang.org, ahe

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix leg build, removed positive check as they fail in leg. The positive test must be somewhere else. Committed: https://code.google.com/p/dart/source/detail?r=3765

Patch Set 1 #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	tests/language/language-leg.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	tests/language/src/LiteralUnaryPlusTest.dart	View		1 chunk	+0 lines, -2 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

8 years, 8 months ago (2012-04-20 09:25:56 UTC) #4

FYI.

This has been sitting in my inbox for a while, but I wanted to make sure we had
the coverage. FWIW, dart2js now handles this.

https://chromiumcodereview.appspot.com/9317021/diff/1/tests/language/src/Lite...
File tests/language/src/LiteralUnaryPlusTest.dart (left):

https://chromiumcodereview.appspot.com/9317021/diff/1/tests/language/src/Lite...
tests/language/src/LiteralUnaryPlusTest.dart:12: var z = +12;
This is tested by language/Unary2Test.

https://chromiumcodereview.appspot.com/9317021/diff/1/tests/language/src/Lite...
tests/language/src/LiteralUnaryPlusTest.dart:13: var y = +.2;
Ditto.

Expand Messages | Collapse Messages