Issue 9316100: Fix for issue 1307: throw runtime exception instead of reporting a compile time error if a static...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9316100: Fix for issue 1307: throw runtime exception instead of reporting a compile time error if a static... (Closed)

Created:
8 years, 10 months ago by srdjan

Modified:
8 years, 10 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix for issue 1307: throw runtime exception instead of reporting a compile time error if a static call cannot be resolved. Committed: https://code.google.com/p/dart/source/detail?r=3922

Patch Set 4 : '' #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -11 lines)			Patch
M	runtime/lib/error.cc	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download
M	runtime/lib/error.dart	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 2 3	2 chunks	+16 lines, -1 line	0 comments	Download
M	runtime/vm/resolver.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/resolver.cc	View	1	2 chunks	+15 lines, -5 lines	0 comments	Download
M	tests/language/language.status	View	1 2	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

On 2012/02/03 17:02:31, srdjan wrote: Throw exception if arguments mismatch, report compilation error if the ...

8 years, 10 months ago (2012-02-03 21:31:59 UTC) #2

regis

LGTM https://chromiumcodereview.appspot.com/9316100/diff/2004/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://chromiumcodereview.appspot.com/9316100/diff/2004/runtime/vm/parser.cc#newcode5808 runtime/vm/parser.cc:5808: kThrowNewName, Fix indentation

8 years, 10 months ago (2012-02-03 21:51:15 UTC) #3

srdjan

8 years, 10 months ago (2012-02-03 22:22:53 UTC) #4

https://chromiumcodereview.appspot.com/9316100/diff/2004/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://chromiumcodereview.appspot.com/9316100/diff/2004/runtime/vm/parser.cc...
runtime/vm/parser.cc:5808: kThrowNewName,
On 2012/02/03 21:51:15, regis wrote:
> Fix indentation

Done.

Expand Messages | Collapse Messages

Issue 9316100: Fix for issue 1307: throw runtime exception instead of reporting a compile time error if a static... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages