Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 9316023: Make XMLHttpRequest.response available. (Closed)

Created:
8 years, 10 months ago by sra1
Modified:
8 years, 10 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org, sethladd
Visibility:
Public.

Description

Make XMLHttpRequest.response available. Not all types are available through responseText, responseXML etc. In particular, arraybuffers need the .response getter. The getter was missing from the Dart interfaces because it is declared in the IDL as returning type 'Object' which is not declared anywhere. Solved by parsing 'object' and 'Object' identically. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3778

Patch Set 1 #

Patch Set 2 : spelling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M client/dom/frog/dom_frog.dart View 4 chunks +8 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/JavaScriptCallFrame.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/XMLHttpRequest.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/JavaScriptCallFrame.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/XMLHttpRequest.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_JavaScriptCallFrameWrappingImplementation.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_XMLHttpRequestWrappingImplementation.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M client/dom/generated/wrapping_dom.js View 2 chunks +16 lines, -0 lines 0 comments Download
M client/dom/generated/wrapping_dom_externs.js View 2 chunks +2 lines, -0 lines 0 comments Download
M client/dom/scripts/idlparser.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sra1
tbr
8 years, 10 months ago (2012-02-01 07:44:32 UTC) #1
vsm
8 years, 10 months ago (2012-02-01 15:30:03 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698