Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9315061: Specify the types for Element.classes, Element.elements and Node.nodes (Closed)

Created:
8 years, 10 months ago by zundel
Modified:
8 years, 9 months ago
Reviewers:
nweiz, scheglov, gbracha
CC:
reviews_dartlang.org, messick
Visibility:
Public.

Description

Specify the types for Element.classes, Element.elements and Node.nodes Previously these lines gave type errors in dartc, but now they pass without warnings. b/5392897 Committed: https://code.google.com/p/dart/source/detail?r=5136

Patch Set 1 #

Patch Set 2 : Fixed place where Collection<E> was treated as List<E> #

Total comments: 2

Patch Set 3 : Dartc change to suppport getter and setter with different types #

Patch Set 4 : Added unit test #

Patch Set 5 : Fixed dynamic type error issue with VM. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -89 lines) Patch
M client/dom/templates/html/interface/interface_Element.darttemplate View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M client/dom/templates/html/interface/interface_Node.darttemplate View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M client/html/generated/html/interface/Node.dart View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M client/html/release/html.dart View 1 2 4 chunks +5 lines, -8 lines 0 comments Download
M client/html/src/DocumentFragmentWrappingImplementation.dart View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M client/html/src/Node.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M client/html/src/SVGElementWrappingImplementation.dart View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M client/html/src/XMLDocumentWrappingImplementation.dart View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M client/html/src/XMLElementWrappingImplementation.dart View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Elements.java View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/type/DynamicTypeImplementation.java View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/type/InterfaceType.java View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/type/InterfaceTypeImplementation.java View 1 2 3 chunks +48 lines, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 1 2 3 5 chunks +62 lines, -56 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 1 2 3 4 chunks +45 lines, -2 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java View 1 2 3 4 chunks +1 line, -3 lines 0 comments Download
A tests/language/src/GettersSetters2Test.dart View 1 2 3 4 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
zundel
See related editor issue: http://code.google.com/p/dart/issues/detail?id=380
8 years, 10 months ago (2012-02-02 16:51:47 UTC) #1
zundel
On 2012/02/02 16:51:47, zundel wrote: > See related editor issue: > > http://code.google.com/p/dart/issues/detail?id=380 Hold up ...
8 years, 10 months ago (2012-02-02 17:04:16 UTC) #2
zundel
Ready for review - patch set 2 fixes the issue I saw earlier.
8 years, 10 months ago (2012-02-02 18:24:54 UTC) #3
nweiz
https://chromiumcodereview.appspot.com/9315061/diff/3001/client/html/src/SVGElementWrappingImplementation.dart File client/html/src/SVGElementWrappingImplementation.dart (right): https://chromiumcodereview.appspot.com/9315061/diff/3001/client/html/src/SVGElementWrappingImplementation.dart#newcode32 client/html/src/SVGElementWrappingImplementation.dart:32: if (parentTag.elements.length == 1) return parentTag.elements.iterator().next(); Line length. Why ...
8 years, 10 months ago (2012-02-02 19:01:11 UTC) #4
zundel
I finally got back to this patch today. https://chromiumcodereview.appspot.com/9315061/diff/3001/client/html/src/SVGElementWrappingImplementation.dart File client/html/src/SVGElementWrappingImplementation.dart (right): https://chromiumcodereview.appspot.com/9315061/diff/3001/client/html/src/SVGElementWrappingImplementation.dart#newcode32 client/html/src/SVGElementWrappingImplementation.dart:32: if ...
8 years, 9 months ago (2012-03-06 20:16:44 UTC) #5
nweiz
This should also be changed in the other places the bug is references (the new ...
8 years, 9 months ago (2012-03-06 21:19:52 UTC) #6
zundel
8 years, 9 months ago (2012-03-06 23:34:13 UTC) #7
zundel
@Gilad, would you mind reviewing the new unit test, which implements that static-warning described in ...
8 years, 9 months ago (2012-03-06 23:35:47 UTC) #8
nweiz
lgtm for the HTML changes.
8 years, 9 months ago (2012-03-07 01:33:45 UTC) #9
scheglov
LGMT for DartC changes.
8 years, 9 months ago (2012-03-07 14:04:30 UTC) #10
gbracha
8 years, 9 months ago (2012-03-07 21:52:17 UTC) #11 
lgtm w/usual comment about static type WARNINGS, not errors.

Powered by Google App Engine
This is Rietveld 408576698