Issue 9315037: Wait for exit-code thread to terminate before terminating main.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9315037: Wait for exit-code thread to terminate before terminating main. (Closed)

Created:
8 years, 10 months ago by Mads Ager (google)

Modified:
8 years, 10 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Wait for exit-code thread to terminate before terminating main. The code is identical on Linux and Mac. Currently unimplemented on Windows because I had to revert my change to the exit code handling on Windows. I will revive that change tomorrow and implement this as part of that change. R=iposva@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3801

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment. Added updated test binaries. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, --2 lines)			Patch
M	runtime/bin/main.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	runtime/bin/process.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/bin/process_linux.cc	View	1	4 chunks	+42 lines, -0 lines	0 comments	Download
M	runtime/bin/process_macos.cc	View	1	4 chunks	+42 lines, -0 lines	0 comments	Download
M	runtime/bin/process_win.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	tools/testing/bin/linux/dart	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tools/testing/bin/macos/dart	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with comment. -Ivan https://chromiumcodereview.appspot.com/9315037/diff/1/runtime/bin/process_linux.cc File runtime/bin/process_linux.cc (right): https://chromiumcodereview.appspot.com/9315037/diff/1/runtime/bin/process_linux.cc#newcode104 runtime/bin/process_linux.cc:104: static const uint8_t kThreadTerminateByte = ...

8 years, 10 months ago (2012-02-01 18:09:24 UTC) #2

Mads Ager (google)

8 years, 10 months ago (2012-02-01 18:15:18 UTC) #3

Thanks Ivan. Updated linux and mac test binaries and committed.

https://chromiumcodereview.appspot.com/9315037/diff/1/runtime/bin/process_lin...
File runtime/bin/process_linux.cc (right):

https://chromiumcodereview.appspot.com/9315037/diff/1/runtime/bin/process_lin...
runtime/bin/process_linux.cc:104: static const uint8_t kThreadTerminateByte = 1;
On 2012/02/01 18:09:24, Ivan Posva wrote:
> Why public? This is only used from within ExitCodeHandler.

Good point. Done.

Expand Messages | Collapse Messages