Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 9315036: Change output of test.dart --list option, so it can be parsed automatically. (Closed)

Created:
8 years, 10 months ago by Bill Hesse
Modified:
8 years, 10 months ago
Reviewers:
ahe, Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change output of test.dart --list option, so it can be parsed automatically. The framework that lets shared tests be run in Eclipse uses the output of this command, and this framework is tested when running test.dart --component=dartc dartc/junit_tests. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3891

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change output of list command. #

Patch Set 3 : more changes #

Patch Set 4 : more changes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -5 lines) Patch
M compiler/javatests/com/google/dart/corelib/SharedTestCase.java View 1 2 1 chunk +3 lines, -1 line 1 comment Download
M compiler/javatests/com/google/dart/corelib/SharedTests.java View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tools/testing/dart/test_options.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/testing/dart/test_progress.dart View 1 2 2 chunks +14 lines, -0 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 2 chunks +8 lines, -2 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Bill Hesse
This is not quite satisfactory yet - it hasn't been tested in Eclipse, and I ...
8 years, 10 months ago (2012-02-01 17:14:55 UTC) #1
ahe
Let's look at this together when I'm back in the office.
8 years, 10 months ago (2012-02-02 14:02:28 UTC) #2
ahe
https://chromiumcodereview.appspot.com/9315036/diff/1/compiler/javatests/com/google/dart/corelib/SharedTestCase.java File compiler/javatests/com/google/dart/corelib/SharedTestCase.java (right): https://chromiumcodereview.appspot.com/9315036/diff/1/compiler/javatests/com/google/dart/corelib/SharedTestCase.java#newcode282 compiler/javatests/com/google/dart/corelib/SharedTestCase.java:282: if (fields.length <= 3) return null; This change concerns ...
8 years, 10 months ago (2012-02-03 11:05:38 UTC) #3
Bill Hesse
OK, comments are addressed. This should be fine to commit - it is tested, and ...
8 years, 10 months ago (2012-02-03 11:55:56 UTC) #4
ahe
8 years, 10 months ago (2012-02-03 11:57:36 UTC) #5
LGTM!

https://chromiumcodereview.appspot.com/9315036/diff/3003/compiler/javatests/c...
File compiler/javatests/com/google/dart/corelib/SharedTestCase.java (right):

https://chromiumcodereview.appspot.com/9315036/diff/3003/compiler/javatests/c...
compiler/javatests/com/google/dart/corelib/SharedTestCase.java:283:
fail("SharedTestCase.java(284): Line is not parsable: " + line);
No need to insert the filename and line number. The stack traces take care of
that.

Powered by Google App Engine
This is Rietveld 408576698