Issue 9310119: Add ImplementedBy attribute for operations merged from [Supplemental=XXX] interfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9310119: Add ImplementedBy attribute for operations merged from [Supplemental=XXX] interfaces. (Closed)

Created:
8 years, 10 months ago by podivilov

Modified:
8 years, 10 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add ImplementedBy attribute for operations merged from [Supplemental=XXX] interfaces. C++ implementations need to know webcore factory name. R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=4209

Patch Set 1 #

Total comments: 1

Patch Set 2 : Move new code to _merge_interfaces #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	client/dom/scripts/databasebuilder.py	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sra1

https://chromiumcodereview.appspot.com/9310119/diff/1/client/dom/scripts/databasebuilder.py File client/dom/scripts/databasebuilder.py (right): https://chromiumcodereview.appspot.com/9310119/diff/1/client/dom/scripts/databasebuilder.py#newcode471 client/dom/scripts/databasebuilder.py:471: if operation.id in operations: Is it possible that foo(int) ...

8 years, 10 months ago (2012-02-06 18:14:36 UTC) #2

podivilov

On 2012/02/06 18:14:36, sra1 wrote: > https://chromiumcodereview.appspot.com/9310119/diff/1/client/dom/scripts/databasebuilder.py > File client/dom/scripts/databasebuilder.py (right): > > https://chromiumcodereview.appspot.com/9310119/diff/1/client/dom/scripts/databasebuilder.py#newcode471 > ...

8 years, 10 months ago (2012-02-10 16:00:09 UTC) #3

lgtm

Expand Messages | Collapse Messages