Issue 9310097: skip invalid JS tests on IE as well

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9310097: skip invalid JS tests on IE as well (Closed)

Created:
8 years, 10 months ago by Jennifer Messerly

Modified:
8 years, 10 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

For some negative tests, Frog generates invalid JS (bad labels), and this causes bad behavior in webdriver because it never gets the termination signal. Committed: https://code.google.com/p/dart/source/detail?r=4017

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	tests/language/language.status	View		2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

I'll also file a bug about the invalid generated code

8 years, 10 months ago (2012-02-03 23:12:18 UTC) #1

Emily Fortuna

8 years, 10 months ago (2012-02-03 23:14:29 UTC) #2

lgtm! 

Perhaps later you should take a brief look at other tests that I marked failing
on specific browsers. I had so many failures, I didn't bother to investigate why
at the time.

Expand Messages | Collapse Messages