Issue 9310096: Fix DartRunner to work properly with --check-only cmdline flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9310096: Fix DartRunner to work properly with --check-only cmdline flag (Closed)

Created:
8 years, 10 months ago by zundel

Modified:
8 years, 10 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix DartRunner to work properly with --check-only cmdline flag Committed: https://code.google.com/p/dart/source/detail?r=3944

Patch Set 2 : Updated copyright #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -9 lines)			Patch
	M	compiler/java/com/google/dart/runner/DartRunner.java	View	1	6 chunks	+13 lines, -9 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

zundel

I found some NPEs while working on a quick proof of concept to see what ...

8 years, 10 months ago (2012-02-03 22:56:22 UTC) #1

scheglov

LGTM https://chromiumcodereview.appspot.com/9310096/diff/2001/compiler/java/com/google/dart/runner/DartRunner.java File compiler/java/com/google/dart/runner/DartRunner.java (right): https://chromiumcodereview.appspot.com/9310096/diff/2001/compiler/java/com/google/dart/runner/DartRunner.java#newcode306 compiler/java/com/google/dart/runner/DartRunner.java:306: final DartRunnerOptions options) throws RunnerError { Would be ...

8 years, 10 months ago (2012-02-06 13:09:54 UTC) #2