Run all directory async operations on a separate thread using native ports

Run all directory async operations on a separate thread using native ports

R=ager@google.com

BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=4390

[Søren Gjesse, 2012-02-03 13:52:52]

Der var den!

This change depends on the following pending changes

https://chromiumcodereview.appspot.com/9104041/
https://chromiumcodereview.appspot.com/9325022/

[Mads Ager (google), 2012-02-03 14:09:32]

Except for the verbosity of the CMessage construction this looks great!

As we just discussed, we need to use only one native port on which all messages
are serialized for a given Directory object.

https://chromiumcodereview.appspot.com/9310082/diff/1/runtime/bin/directory.cc
File runtime/bin/directory.cc (right):

https://chromiumcodereview.appspot.com/9310082/diff/1/runtime/bin/directory.c...
runtime/bin/directory.cc:137: Dart_CMessage response;
We should streamline this. 5 lines just to create false. Auch. That's quite a
bit harder than Dart_NewBoolean(false).

https://chromiumcodereview.appspot.com/9310082/diff/1/runtime/bin/directory.c...
runtime/bin/directory.cc:161: if (message->root->type == Dart_CObject::kString)
{
This takes a bool too now. Should be easy to update this to take that into
account.

https://chromiumcodereview.appspot.com/9310082/diff/1/runtime/bin/directory.c...
runtime/bin/directory.cc:162: bool created =
Directory::Delete(message->root->value.as_string);
deleted

[Søren Gjesse, 2012-02-15 15:09:39]

Addressed the comments and updated to use the CObject utilities from
http://codereview.chromium.org/9403012/.

I will update this change with the port of the rest of the directory async
operations.

http://codereview.chromium.org/9310082/diff/1/runtime/bin/directory.cc
File runtime/bin/directory.cc (right):

http://codereview.chromium.org/9310082/diff/1/runtime/bin/directory.cc#newcod...
runtime/bin/directory.cc:137: Dart_CMessage response;
On 2012/02/03 14:09:32, Mads Ager wrote:
> We should streamline this. 5 lines just to create false. Auch. That's quite a
> bit harder than Dart_NewBoolean(false).

Working on adding dartutil stuff for this while porting to use native ports.

http://codereview.chromium.org/9310082/diff/1/runtime/bin/directory.cc#newcod...
runtime/bin/directory.cc:161: if (message->root->type == Dart_CObject::kString)
{
On 2012/02/03 14:09:32, Mads Ager wrote:
> This takes a bool too now. Should be easy to update this to take that into
> account. 

Done.

http://codereview.chromium.org/9310082/diff/1/runtime/bin/directory.cc#newcod...
runtime/bin/directory.cc:162: bool created =
Directory::Delete(message->root->value.as_string);
On 2012/02/03 14:09:32, Mads Ager wrote:
> deleted

Done.

[Søren Gjesse, 2012-02-16 15:10:27]

Ported all operations. Changed issue description to match that.

PTAL.

[Mads Ager (google), 2012-02-20 12:56:38]

LGTM

http://codereview.chromium.org/9310082/diff/10002/runtime/bin/directory.cc
File runtime/bin/directory.cc (right):

http://codereview.chromium.org/9310082/diff/10002/runtime/bin/directory.cc#ne...
runtime/bin/directory.cc:237: service_port = 
Dart_NewNativePort("DirectoryService",
Are there two spaces after the '=' here?

http://codereview.chromium.org/9310082/diff/10002/runtime/bin/directory.h
File runtime/bin/directory.h (right):

http://codereview.chromium.org/9310082/diff/10002/runtime/bin/directory.h#new...
runtime/bin/directory.h:53: DirectoryListing *listing);
Placement of '*'

http://codereview.chromium.org/9310082/diff/10002/runtime/bin/directory_impl....
File runtime/bin/directory_impl.dart (right):

http://codereview.chromium.org/9310082/diff/10002/runtime/bin/directory_impl....
runtime/bin/directory_impl.dart:37: var handler =
Two-space indentation please. Here and in all the ones below as well.

http://codereview.chromium.org/9310082/diff/10002/runtime/bin/directory_posix.cc
File runtime/bin/directory_posix.cc (right):

http://codereview.chromium.org/9310082/diff/10002/runtime/bin/directory_posix...
runtime/bin/directory_posix.cc:33: DirectoryListing *listing);
Style: '*'

Here and multiple occurrences below.

http://codereview.chromium.org/9310082/diff/10002/runtime/bin/directory_posix...
runtime/bin/directory_posix.cc:88: // TODO(sgjesse): Pass flags to indicate
whether file responses are
We should file a bug report for these TODOs to make sure that we track them.

[Søren Gjesse, 2012-02-21 11:23:24]

http://codereview.chromium.org/9310082/diff/10002/runtime/bin/directory.cc
File runtime/bin/directory.cc (right):

http://codereview.chromium.org/9310082/diff/10002/runtime/bin/directory.cc#ne...
runtime/bin/directory.cc:237: service_port = 
Dart_NewNativePort("DirectoryService",
On 2012/02/20 12:56:38, Mads Ager wrote:
> Are there two spaces after the '=' here?

Yes, removed one.

http://codereview.chromium.org/9310082/diff/10002/runtime/bin/directory.h
File runtime/bin/directory.h (right):

http://codereview.chromium.org/9310082/diff/10002/runtime/bin/directory.h#new...
runtime/bin/directory.h:53: DirectoryListing *listing);
On 2012/02/20 12:56:38, Mads Ager wrote:
> Placement of '*'

Done.

http://codereview.chromium.org/9310082/diff/10002/runtime/bin/directory_impl....
File runtime/bin/directory_impl.dart (right):

http://codereview.chromium.org/9310082/diff/10002/runtime/bin/directory_impl....
runtime/bin/directory_impl.dart:37: var handler =
On 2012/02/20 12:56:38, Mads Ager wrote:
> Two-space indentation please. Here and in all the ones below as well.

Done.

http://codereview.chromium.org/9310082/diff/10002/runtime/bin/directory_posix.cc
File runtime/bin/directory_posix.cc (right):

http://codereview.chromium.org/9310082/diff/10002/runtime/bin/directory_posix...
runtime/bin/directory_posix.cc:33: DirectoryListing *listing);
On 2012/02/20 12:56:38, Mads Ager wrote:
> Style: '*'
> 
> Here and multiple occurrences below.

Done.

http://codereview.chromium.org/9310082/diff/10002/runtime/bin/directory_posix...
runtime/bin/directory_posix.cc:88: // TODO(sgjesse): Pass flags to indicate
whether file responses are
On 2012/02/20 12:56:38, Mads Ager wrote:
> We should file a bug report for these TODOs to make sure that we track them.

Will do after committing.