Issue 9310061: Fix for extra memory consumption.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9310061: Fix for extra memory consumption. (Closed)

Created:
8 years, 10 months ago by scheglov

Modified:
8 years, 10 months ago

Reviewers:
zundel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix for extra memory consumption. Especially in the big List.sort() test. R=zundel@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3846

Patch Set 1 #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -12 lines)			Patch
M	compiler/java/com/google/dart/compiler/DartCompiler.java	View	1 chunk	+11 lines, -9 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/DartCompilerMainContext.java	View	2 chunks	+2 lines, -2 lines	1 comment	Download
M	compiler/scripts/dartc_test.sh	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

https://chromiumcodereview.appspot.com/9310061/diff/1/compiler/java/com/google/dart/compiler/DartCompilerMainContext.java File compiler/java/com/google/dart/compiler/DartCompilerMainContext.java (right): https://chromiumcodereview.appspot.com/9310061/diff/1/compiler/java/com/google/dart/compiler/DartCompilerMainContext.java#newcode38 compiler/java/com/google/dart/compiler/DartCompilerMainContext.java:38: private final Map<Source, List<DartCompilationError>> errors = Maps.newHashMap(); Because DartCompilationError ...

8 years, 10 months ago (2012-02-02 14:39:18 UTC) #2

lgtm

Expand Messages | Collapse Messages