Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 9310059: Nuke DOMImplementation.hasFeature test for Dart support. (Closed)

Created:
8 years, 10 months ago by antonm
Modified:
8 years, 10 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org, sethladd
Visibility:
Public.

Description

Nuke DOMImplementation.hasFeature test for Dart support. Committed: https://code.google.com/p/dart/source/detail?r=3890

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M client/dart.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
antonm
8 years, 10 months ago (2012-02-02 14:29:14 UTC) #1
vsm
LGTM Is it time to update: http://synonym.dartlang.org/ as well?
8 years, 10 months ago (2012-02-02 15:49:13 UTC) #2
antonm
8 years, 10 months ago (2012-02-02 15:59:57 UTC) #3
Thanks a lot for review, Vijay!

I am planning to submit it tomorrow to minimize possible breakage.

But I think we should update documentation with webkitStartDart already (the
change went it) and probably synonyms as well.

Powered by Google App Engine
This is Rietveld 408576698