Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 9310007: Allow assignment expressions in conditional expressions (Closed)

Created:
8 years, 10 months ago by hausner
Modified:
8 years, 10 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow assignment expressions in conditional expressions Fix issue 1243 (http://code.google.com/p/dart/issues/detail?id=1243) Also fix issue 1370 (name of internal temporary variables, order of expression evaluation.) Committed: https://code.google.com/p/dart/source/detail?r=3768

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -16 lines) Patch
M runtime/vm/parser.cc View 1 2 4 chunks +20 lines, -16 lines 0 comments Download
A tests/language/src/CondExprTest.dart View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
hausner
8 years, 10 months ago (2012-01-31 22:01:13 UTC) #1
srdjan
8 years, 10 months ago (2012-02-01 00:37:48 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698