Implement script tags.

Implement script tags.

Committed: https://code.google.com/p/dart/source/detail?r=3909

[kasperl, 2012-02-03 11:51:37]

LGTM.

https://chromiumcodereview.appspot.com/9309061/diff/1/dart/frog/leg/scanner/s...
File dart/frog/leg/scanner/scanner_task.dart (right):

https://chromiumcodereview.appspot.com/9309061/diff/1/dart/frog/leg/scanner/s...
dart/frog/leg/scanner/scanner_task.dart:72: newLibrary = true;
Weird indentation.

[ngeoffray, 2012-02-03 12:12:24]

LGTM!

[ahe, 2012-02-03 17:36:19]

https://chromiumcodereview.appspot.com/9309061/diff/1/dart/frog/leg/scanner/s...
File dart/frog/leg/scanner/scanner_task.dart (right):

https://chromiumcodereview.appspot.com/9309061/diff/1/dart/frog/leg/scanner/s...
dart/frog/leg/scanner/scanner_task.dart:72: newLibrary = true;
On 2012/02/03 11:51:37, kasperl wrote:
> Weird indentation.

This is what Dart mode in Emacs does. What would you like to see?

[kasperl, 2012-02-05 07:58:28]

https://chromiumcodereview.appspot.com/9309061/diff/1/dart/frog/leg/scanner/s...
File dart/frog/leg/scanner/scanner_task.dart (right):

https://chromiumcodereview.appspot.com/9309061/diff/1/dart/frog/leg/scanner/s...
dart/frog/leg/scanner/scanner_task.dart:72: newLibrary = true;
On 2012/02/03 17:36:19, ahe wrote:
> On 2012/02/03 11:51:37, kasperl wrote:
> > Weird indentation.
> 
> This is what Dart mode in Emacs does. What would you like to see?

I'd much prefer something like this:

   xxx.yyy.zzz(..., () {
     hest;
     fisk;
   });

Looks more like regular control flow that way.

[sra1, 2012-02-05 19:01:37]

https://chromiumcodereview.appspot.com/9309061/diff/1/dart/frog/leg/scanner/s...
File dart/frog/leg/scanner/scanner_task.dart (right):

https://chromiumcodereview.appspot.com/9309061/diff/1/dart/frog/leg/scanner/s...
dart/frog/leg/scanner/scanner_task.dart:72: newLibrary = true;
On 2012/02/05 07:58:29, kasperl wrote:
> On 2012/02/03 17:36:19, ahe wrote:
> > On 2012/02/03 11:51:37, kasperl wrote:
> > > Weird indentation.
> > 
> > This is what Dart mode in Emacs does. What would you like to see?
> 
> I'd much prefer something like this:
> 
>    xxx.yyy.zzz(..., () {
>      hest;
>      fisk;
>    });
> 
> Looks more like regular control flow that way.

Emacs is closer to the style guide.

Style guide says "DO indent continued lines with four spaces."
Since there are two levels of nesting here, ({, I think the body should be
indented not less than +4.

If you broke the arguments at the comma, you should have +4 for "() {" and
another +2 for the body.

[ahe, 2012-02-05 19:20:58]

On 2012/02/05 19:01:37, sra1 wrote:
>
https://chromiumcodereview.appspot.com/9309061/diff/1/dart/frog/leg/scanner/s...
> File dart/frog/leg/scanner/scanner_task.dart (right):
> 
>
https://chromiumcodereview.appspot.com/9309061/diff/1/dart/frog/leg/scanner/s...
> dart/frog/leg/scanner/scanner_task.dart:72: newLibrary = true;
> On 2012/02/05 07:58:29, kasperl wrote:
> > On 2012/02/03 17:36:19, ahe wrote:
> > > On 2012/02/03 11:51:37, kasperl wrote:
> > > > Weird indentation.
> > > 
> > > This is what Dart mode in Emacs does. What would you like to see?
> > 
> > I'd much prefer something like this:
> > 
> >    xxx.yyy.zzz(..., () {
> >      hest;
> >      fisk;
> >    });
> > 
> > Looks more like regular control flow that way.
> 
> Emacs is closer to the style guide.
> 
> Style guide says "DO indent continued lines with four spaces."
> Since there are two levels of nesting here, ({, I think the body should be
> indented not less than +4.
> 
> If you broke the arguments at the comma, you should have +4 for "() {" and
> another +2 for the body.

As far as I know, no Smalltalkers were consulted on the style guide ;-)

[Lasse Reichstein Nielsen, 2012-02-05 21:08:10]

On 2012/02/05 19:01:37, sra1 wrote:
>
https://chromiumcodereview.appspot.com/9309061/diff/1/dart/frog/leg/scanner/s...
> File dart/frog/leg/scanner/scanner_task.dart (right):
> 
>
https://chromiumcodereview.appspot.com/9309061/diff/1/dart/frog/leg/scanner/s...
> dart/frog/leg/scanner/scanner_task.dart:72: newLibrary = true;
> On 2012/02/05 07:58:29, kasperl wrote:
> > On 2012/02/03 17:36:19, ahe wrote:
> > > On 2012/02/03 11:51:37, kasperl wrote:
> > > > Weird indentation.
> > > 
> > > This is what Dart mode in Emacs does. What would you like to see?
> > 
> > I'd much prefer something like this:
> > 
> >    xxx.yyy.zzz(..., () {
> >      hest;
> >      fisk;
> >    });
> > 
> > Looks more like regular control flow that way.
> 
> Emacs is closer to the style guide.
> 
> Style guide says "DO indent continued lines with four spaces."
> Since there are two levels of nesting here, ({, I think the body should be
> indented not less than +4.

The style guide continues:
"The one exception to this is function expressions used within larger
expressions, like being passed to methods. These are formatted like so:" (and
continues with somethine indented the way Kasper showed it).

And I also think it reads better. It's what I would do in JS too.
/L